GetLineMarksManager should be public?

 

I was trying to implement a "Remove all breakpoints"-function. This was my first attempt:

 

for (int i = 1; i <= GetEditCtrl().GetRowCount(); i++)
    GetEditCtrl().DeleteBreakpoint(i);

However, that yields a crash in CArray due to an index value of -1. I think this is a bug:

void CXTPSyntaxEditLineMarksManager::CLineMarksList::Remove(const int nKey)
{
    int nIndex = FindIndex(nKey);
    // BUG? if (nKey >= 0)

    if (nIndex >= 0) // This seems more logical :)

    ...
}

 

Wouldn't it be better if GetLineMarksManager() was public or at least protected? In this case, it seems hard to fix the above without recompiling the source code. Calling HasRowMark(...) before the deletion solves it, but then you need to redraw the line marks. You cannot do this with RedrawLineMarks() since it is protected. Anyway, this is how I solved it:

 

for (int i = 1; i <= GetEditCtrl().GetRowCount(); i++)
{
    if (GetEditCtrl().HasRowMark(i, xtpEditLMT_Breakpoint))
        GetEditCtrl().DeleteBreakpoint(i);
}
GetEditCtrl().Invalidate();