Access violation CXTPMenuBar::LoadMenu

I figured out a "fix".  You'll notice that we are calling CXTPControls::RemoveAll.  This method basically cleans up the XTP Controls associated with the menu bar.  There is some smart code here:

void CXTPControls::RemoveAll(void)  ORIGINAL CODE
{
 for (int nIndex = 0; nIndex < GetCount(); nIndex++)
 {
  CXTPControl* pControl = m_arrControls.GetAt(nIndex);
  pControl->m_pControls = NULL;
  pControl->m_pParent = NULL;
  pControl->InternalRelease();
 } 
 m_arrControls.RemoveAll();
}

All references between the container and the menu bar should have been taken care of before the call to InteralRelease (where it's initialyzing the two pointers to NULL).

But for some reason, the InternalRelease call ends up accessing the same container way down the stack in the CXTPControls::CalcDynamicSize method (I checked the pointer of the CXTPControls this pointer, and they match).

I rewrote the CXTPControls::RemoveAll method to basically copy the control pointers into a temporary automatic CArray<CXTPControl*, CXTPControl*> array, call RemoveAll on the CXTPControls::m_arrControls before the loop, then loop through the temporary array.

Here's the new code, but I am not 100% sure if it causes any side effects:

void CXTPControls::RemoveAll(void)  NEW CODE
{
   CArray<CXTPControl*, CXTPControl*> aTemp;  // temp controls container
   const int nSize = GetCount();
   aTemp.SetSize(nSize);  // set temp's container size then copy

   // copy everything from m_arrControls to aTemp
   for (int nIndex = 0; nIndex < nSize; nIndex++)
      {
      aTemp.SetAt(nIndex, m_arrControls.GetAt(nIndex));
      }

   m_arrControls.RemoveAll();  // clear out member container

   // now loop through aTemp and clean up controls
   for (int nIndex = 0; nIndex < nSize; nIndex++)
   {
      CXTPControl* pControl = aTemp.GetAt(nIndex);
      pControl->m_pControls = NULL;
      pControl->m_pParent = NULL;
      pControl->InternalRelease();
   }  
   aTemp.RemoveAll();
}

Anyone want to comment??

This is the method that calls the LoadMenu method on the MenuBar object (at the bottom of the method).  Below this method is the OnActivateView method which
"calls" the OnInitMenu via the WM_INITMENU message.

void CProgramFrameD::OnInitMenu(CMenu* pMenu)
   {
   char Buffer[100];
   BOOL MainMenu = FALSE;
     
   if (pProj->GetKB())
      {     
      for (UINT x=0; x<pMenu->GetMenuItemCount(); x++)
         {
         pMenu->GetMenuString(x, Buffer, sizeof(Buffer), MF_BYPOSITION);
        
         if (!strcmp(Buffer, (char *) ViewString))   // "&View"
             {
             BuildViewMenu(pMenu->GetSubMenu(x));
             //break;
             }
         else if (!strcmp(Buffer, (char *) FileString))
             {
             if (!pMenu->GetSubMenu(x))
                pMenu->ModifyMenu(x, MF_POPUP | MF_BYPOSITION, (UINT) FileMenu.GetSafeHmenu(), (char *) FileString);
//                 pMenu->ModifyMenu(x, MF_POPUP | MF_BYPOSITION, (UINT) FileMenu, (char *) FileString);
             }
         else if (!strcmp(Buffer, (char *) HelpString))
             {
             if (!pMenu->GetSubMenu(x))
                pMenu->ModifyMenu(x, MF_POPUP | MF_BYPOSITION, (UINT) HelpMenu.GetSafeHmenu(), (char *) HelpString);
//                 pMenu->ModifyMenu(x, MF_POPUP | MF_BYPOSITION, (UINT) HelpMenu, (char *) HelpString);
             }
         else if (!strcmp(Buffer, (char *) WindowString))       &nbs p;
             {
             if (!pMenu->GetSubMenu(x))
                pMenu->ModifyMenu(x, MF_POPUP | MF_BYPOSITION, (UINT) WindowMenu.GetSafeHmenu(), (char *) WindowString);
//                 pMenu->ModifyMenu(x, MF_POPUP | MF_BYPOSITION, (UINT) WindowMenu, (char *) WindowString);
             }
         else if (!strcmp(Buffer, (char *) ToolsString))         ;
             {
             if (!pMenu->GetSubMenu(x))
                pMenu->ModifyMenu(x, MF_POPUP | MF_BYPOSITION, (UINT) ToolsMenu.GetSafeHmenu(), (char *) ToolsString);
//                 pMenu->ModifyMenu(x, MF_POPUP | MF_BYPOSITION, (UINT) ToolsMenu, (char *) ToolsString);
             }
         }
      }
  
//   CHostMDI::OnInitMenu(pMenu);
     
   // If we have a knowledge base then let it have a chance to change the menu.
   if (pProj->GetKB())
      pProj->GetKB()->HostMessage(ONINITMENU, (LPARAM) this, (LPARAM)pMenu);

   BroadcastProgramMessage(ONINITMENU, (LPARAM) this, (LPARAM) pMenu);

   // Doug 6/14/05 - Don't update the XTPro Menu here.  Otherwise, we
   //                  get the local menu showing up on the menu bar after
   //                  a right-click.  See DSP5 Problem #49.
   // Update XTPro menu
   // Doug 6/23/05 - Ok, lets go back and fix the problem I created by
   //                  removing the LoadMenu call.  We need this call to be
   //                  made if and only if we are dealing with the main
   //                  menu...
 
   CString ItemName;
  
   pMenu->GetMenuString(0, ItemName, MF_BYPOSITION);
    
   if (!strncmp(ItemName.GetBuffer(0), (char *) FileString, ItemName.GetLength()))
      GetCommandBars()->GetMenuBar()->LoadMenu(pMenu);

   }

Here's the method that "calls" OnInitMenu for the specific view in question (other views have similar structure).  Only the "CLadView" has an accelerator key assigned to it (Ctrl+L) to bring it up.  It only crashes when it must create the view.  It does not crash if the view already exists and we are only changing focus to that existing view.

void CLadView::OnActivateView( BOOL bActivate, CView* pActivateView, CView* pDeactiveView)
   {
   CGraphicalView::OnActivateView( bActivate, pActivateView, pDeactiveView);
  
   HPrivateIni HostIni(AfxGetHostApp()->GetIniFile());
   //STRINGFIND==OFF
   m_bLadderPalette = HostIni.GetInt(String(IDS_INI_SETUP), "LadderPalette", 1); //STRINGFIND==ON

   if( InEditMode() )
      {
//      HTRACE("CLadView::OnActivateView(%d) calling ShowPalette\n", bActivate);
      //ShowPalette(bActivate && m_bLadderPalette);
      if (!(bActivate && m_bLadderPalette))
         {
         LadderDataClass *pDC = (LadderDataClass *) Proj->GetData(DT_LADDER);
         if (GetPaletteBar())
             {
             delete GetPaletteBar();
             pDC->pPaletteBar = NULL;
             }
         }
      }
  
//   if (SubView && bActivate)
   if (bActivate)
      {
      // Change to the correct menu!
      CMDIChildWnd *pChild = (CMDIChildWnd *) GetParentFrame();
     
      if (pChild)
         {
         CMDIFrameWnd* pFrame = pChild->GetMDIFrame();
     
         if (pFrame)
             {
               LadderDataClass *pLDC = (LadderDataClass *)Proj->GetData(DT_LADDER);

             ::SendMessage(pFrame->m_hWndMDIClient, WM_MDISETMENU, (WPARAM)pLDC->hSharedMenu,
                (LPARAM)(pFrame->GetWindowMenuPopup(pLDC->hSharedMenu) ));
               
             pChild->SendMessage(WM_SETACCELTABLE, 0, (LPARAM) (void *) pLDC->hSharedAccelTable);
        
             pFrame->DrawMenuBar();

             GetProgramFrame()->SendMessage(WM_INITMENU, (WPARAM)pLDC->hSharedMenu, 0);
             }
         }
      }
   }