CXTPRibbonControlTab::OnSetPopup

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

   If a ribbon is minimized, CXTPRibbonControlTab::OnSetPopup calls m_pCOmmandBar->InternalRelease. Then a few lines later it calls CreateTabPopupToolBar. We have code when hide flags are set on a combobox that examines the ribbon bar to find any other combobox the user might have added to the ribbon via customization. That code tests the command bar pointer before looking for any controls in it.

Since the InternalRelease call destroyed the current m_pCommandBar pointer, we are crashing.

I think that after InternalRelease is called, this code should immediately set m_pCommandBar to nullptr.

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
rdhd Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 13 August 2007 Location: United States Status: Offline Points: 886	Post Options Post Reply Quote rdhd Report Post Thanks(0) Quote Reply Topic: CXTPRibbonControlTab::OnSetPopup Posted: 18 August 2021 at 9:01am
	If a ribbon is minimized, CXTPRibbonControlTab::OnSetPopup calls m_pCOmmandBar->InternalRelease. Then a few lines later it calls CreateTabPopupToolBar. We have code when hide flags are set on a combobox that examines the ribbon bar to find any other combobox the user might have added to the ribbon via customization. That code tests the command bar pointer before looking for any controls in it. Since the InternalRelease call destroyed the current m_pCommandBar pointer, we are crashing. I think that after InternalRelease is called, this code should immediately set m_pCommandBar to nullptr.