Codejock Forums Homepage
Forum Home Forum Home > Codejock Products > Visual C++ MFC > Report Control
  New Posts New Posts RSS Feed - [fixed]BUG in CXTPReportSelectedRows::Clear(FALSE)
  FAQ FAQ  Forum Search   Events   Register Register  Login Login

[fixed]BUG in CXTPReportSelectedRows::Clear(FALSE)

 Post Reply Post Reply
Author
Message
mgampi View Drop Down
Senior Member
Senior Member
Avatar

Joined: 14 July 2003
Status: Offline
Points: 1201
Post Options Post Options   Thanks (1) Thanks(1)   Quote mgampi Quote  Post ReplyReply Direct Link To This Post Topic: [fixed]BUG in CXTPReportSelectedRows::Clear(FALSE)
    Posted: 07 September 2016 at 9:53am
Hello;

This function CXTPReportSelectedRows::Clear(BOOL bNotifyOnClear) has no effect when bNotifyOnClear is set to FALSE:

BOOL CXTPReportSelectedRows::Clear(BOOL bNotifyOnClear)
{
    BOOL bClear = FALSE;

    if (m_arrSelectedBlocks.GetSize() > 0)
    {
        if (bNotifyOnClear)
        {
            const BOOL bCancel = _NotifySelChanging(xtpReportSelectionClear);

            if (!bCancel)
            {
                bClear = TRUE;
                m_arrSelectedBlocks.RemoveAll();
                SetChanged(TRUE);
                m_nRowBlockBegin = -1;
                m_nRowType = xtpRowTypeBody;
                m_pControl->RedrawControl();
            }
        }
    }

    return bClear;
}


should be changed to:


BOOL CXTPReportSelectedRows::Clear(BOOL bNotifyOnClear)
{
    BOOL bClear = !bNotifyOnClear;

    if (m_arrSelectedBlocks.GetSize() > 0)
    {
        if (bNotifyOnClear)
            bClear = !_NotifySelChanging(xtpReportSelectionClear);

    if (bClear) {
      m_arrSelectedBlocks.RemoveAll();
      SetChanged(TRUE);
      m_nRowBlockBegin = -1;
      m_nRowType = xtpRowTypeBody;
      m_pControl->RedrawControl();   
    }
    }

    return bClear;
}


Regards!


Martin

Product: Xtreme Toolkit v 22.1.0, new Projects v 24.0.0
Platform: Windows 10 v 22H2 (64bit)
Language: VC++ 2022
Back to Top
olebed View Drop Down
Admin Group
Admin Group


Joined: 01 July 2014
Location: Ukraine
Status: Offline
Points: 841
Post Options Post Options   Thanks (0) Thanks(0)   Quote olebed Quote  Post ReplyReply Direct Link To This Post Posted: 07 September 2016 at 12:43pm
Hello Martin,

Thank you for bug report. I have fixed this method.

Regards,
 Oleksandr Lebed
Back to Top
mgampi View Drop Down
Senior Member
Senior Member
Avatar

Joined: 14 July 2003
Status: Offline
Points: 1201
Post Options Post Options   Thanks (0) Thanks(0)   Quote mgampi Quote  Post ReplyReply Direct Link To This Post Posted: 07 September 2016 at 3:13pm
Originally posted by olebed olebed wrote:

Hello Martin,

Thank you for bug report. I have fixed this method.

Regards,
 Oleksandr Lebed


Thanks for this quick reply!
Any ideas when the next release is due?

Regards,
Martin

Product: Xtreme Toolkit v 22.1.0, new Projects v 24.0.0
Platform: Windows 10 v 22H2 (64bit)
Language: VC++ 2022
Back to Top
olebed View Drop Down
Admin Group
Admin Group


Joined: 01 July 2014
Location: Ukraine
Status: Offline
Points: 841
Post Options Post Options   Thanks (0) Thanks(0)   Quote olebed Quote  Post ReplyReply Direct Link To This Post Posted: 07 September 2016 at 5:21pm
Back to Top
 Post Reply Post Reply
  Share Topic   

Forum Jump Forum Permissions View Drop Down

Forum Software by Web Wiz Forums® version 12.04
Copyright ©2001-2021 Web Wiz Ltd.

This page was generated in 0.203 seconds.