Bug in MTI calculating workspace sizes

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

In CXTPTabClientWnd::CalcWindowRect every workspace size is calculated as if each workspace has its own splitter, which is not true, there is 1 less splitters than workspaces. The lines are:
rc.bottom = nBottom - SPLITTER_HEIGHT;
and
rc.right = nRight - SPLITTER_HEIGHT;

So the workspaces are slightly not the same size by a few pixels, but this can easily be compensated for above by changing
int nTotalHeight = m_bHorizSplitting? rcClient.Height(): rcClient.Width();
to
int nTotalHeight = (m_bHorizSplitting? rcClient.Height(): rcClient.Width()) + SPLITTER_HEIGHT;

Just adding an extra SPLITTER_HEIGHT into the area used to calculate will offset this difference.

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
Ark42 Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 20 October 2003 Status: Offline Points: 291	Post Options Post Reply Quote Ark42 Report Post Thanks(0) Quote Reply Topic: Bug in MTI calculating workspace sizes Posted: 31 March 2005 at 8:42pm
	In CXTPTabClientWnd::CalcWindowRect every workspace size is calculated as if each workspace has its own splitter, which is not true, there is 1 less splitters than workspaces. The lines are: rc.bottom = nBottom - SPLITTER_HEIGHT; and rc.right = nRight - SPLITTER_HEIGHT; So the workspaces are slightly not the same size by a few pixels, but this can easily be compensated for above by changing int nTotalHeight = m_bHorizSplitting? rcClient.Height(): rcClient.Width(); to int nTotalHeight = (m_bHorizSplitting? rcClient.Height(): rcClient.Width()) + SPLITTER_HEIGHT; Just adding an extra SPLITTER_HEIGHT into the area used to calculate will offset this difference.

Oleg Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 21 May 2003 Location: United States Status: Offline Points: 11234	Post Options Post Reply Quote Oleg Report Post Thanks(0) Quote Reply Posted: 06 April 2005 at 4:17am
	Thank you. We changed it.
	Oleg, Support Team CODEJOCK SOFTWARE SOLUTIONS

Ark42 Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 20 October 2003 Status: Offline Points: 291	Post Options Post Reply Quote Ark42 Report Post Thanks(0) Quote Reply Posted: 22 July 2005 at 12:33pm
	This bug is still present in v9.70...

Ark42 Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 20 October 2003 Status: Offline Points: 291	Post Options Post Reply Quote Ark42 Report Post Thanks(0) Quote Reply Posted: 22 July 2005 at 12:52pm
	The problem is now in CXTPTabClientWnd::DoWorkspaceCommand and it is simple to fix. Just change the line in the ACTION_INSERTHORIZ and ACTION_INSERTVERT cases from: pWorkspace->m_dHeight = pFocusWorksapce->m_dHeight / 2; to: pWorkspace->m_dHeight = (pFocusWorksapce->m_dHeight - m_nSplitterSize) / 2;

Oleg Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 21 May 2003 Location: United States Status: Offline Points: 11234	Post Options Post Reply Quote Oleg Report Post Thanks(0) Quote Reply Posted: 26 July 2005 at 2:16am
	Fixed.
	Oleg, Support Team CODEJOCK SOFTWARE SOLUTIONS