Crash in Report Control in 10.4

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

   This worked fine in 10.31, now it crashes in 10.4

Click on a bit of column text in the ReportSample .. all works.

Now, click on the preview text in the report and it crashes.

It is because of (new) changes to OnClick:

void CXTPReportRow::OnClick(CPoint ptClicked)
{
 XTP_REPORTRECORDITEM_CLICKARGS clickArgs;
 clickArgs.pControl = m_pControl;
 clickArgs.pRow = this;
 clickArgs.ptClient = ptClicked;
 clickArgs.pColumn = NULL;
 // find clicked item
 clickArgs.pItem = HitTest(ptClicked, &clickArgs.rcItem, &clickArgs.pColumn);
 if (HasChildren() && m_rcCollapse.PtInRect(ptClicked)
  && clickArgs.pColumn && clickArgs.pColumn->IsTreeColumn())
 {
  SetExpanded(!IsExpanded());
  return;
 }
 // notify item if found
 if (!clickArgs.pItem)
  return;
 clickArgs.pItem->OnClick(&clickArgs);
}

Because on a preview item, HitTest produces a NULL for the pColumn:

 clickArgs.pItem = HitTest(ptClicked, &clickArgs.rcItem, &clickArgs.pColumn);

Therefore:

void CXTPReportRecordItem::OnClick(XTP_REPORTRECORDITEM_CLICKARGS* pClickArgs)
{
 pClickArgs->pRow->InternalAddRef();
 pClickArgs->pColumn->InternalAddRef();
 InternalAddRef();

Causes an access violation.