Codejock Developer Community : [solved] Inplace edit bug!

[solved] Inplace edit bug! : Improvement to the code of my...

Tue, 12 Mar 2024 04:25:57 +0000

Author: mgampi
Subject: 9742
Posted: 12 March 2024 at 4:25am

Improvement to the code of my previous message:

    m_clrText = pMetrics->clrForeground;
    if (pMetrics->clrBackground!=static_cast(-1)) {
      m_clrBack = pMetrics->clrBackground; 
    } else {
      m_clrBack=pControl->GetPaintManager()->m_clrControlBack;
    }
    if (m_xtpBrushBack.GetSafeHandle())
        m_xtpBrushBack.DeleteObject();

[solved] Inplace edit bug! : I have to reopen this issue, because...

Sun, 10 Mar 2024 06:33:53 +0000

Author: mgampi
Subject: 9742
Posted: 10 March 2024 at 6:33am

I have to reopen this issue, because it still does not work as expected in v.22.1.

Suppose you have an alternate coloring in your control and an item of a row with alternate color is edited, then the (false) background color of the control is used.

In CXTPGridInplaceEdit::Create() we can find this code:

    m_clrText = pMetrics->clrForeground;
    m_clrBack = pControl->GetPaintManager()->m_clrControlBack;

    if (m_xtpBrushBack.GetSafeHandle())
        m_xtpBrushBack.DeleteObject();

    m_xtpBrushBack.CreateSolidBrush(m_clrBack);

I believe it should be replaced by:

    m_clrText = pMetrics->clrForeground;
    m_clrBack = pMetrics->clrBackground;

    if (m_xtpBrushBack.GetSafeHandle())
        m_xtpBrushBack.DeleteObject();

    m_xtpBrushBack.CreateSolidBrush(m_clrBack);

to reflect background color changes done with alternate coloring and/or GetItemMetrics(...) callbacks. Another more flexible solution would be a Function CXTPGridInplaceEdit::SetBackgroundColor() and take this, if no color changes are applied with GetItemMetrics() callbacks.

[solved] Inplace edit bug! : Hello,I'm glad inform you...

Sat, 23 Jun 2018 07:20:25 +0000

Author: olebed
Subject: 9742
Posted: 23 June 2018 at 7:20am

Hello,

I'm glad inform you that this have been already implemented in v18.4.

Added CXTPReportInplaceEdit::m_clrBack and appropriate m_xtpBrushBack method for CXTPReportInplaceEdit::CtlColor()

on creation CXTPReportInplaceEdit added initialization

m_clrBack = pControl->GetPaintManager()->m_clrControlBack;

Regards,
Oleksandr Lebed

[solved] Inplace edit bug! : Hi,Thank you for bringing this...

Mon, 01 Dec 2014 10:20:01 +0000

Author: olebed
Subject: 9742
Posted: 01 December 2014 at 10:20am

Hi,

Thank you for bringing this to our attention. I’ve added this to our bug database. The problem will be addressed according to its priority.

Regards,
Lebed Oleksandr

[solved] Inplace edit bug! : Hi;has this ever been implemented...

Sun, 07 Sep 2014 08:29:22 +0000

Author: mgampi
Subject: 9742
Posted: 07 September 2014 at 8:29am

Hi;

has this ever been implemented into the core?

[solved] Inplace edit bug! : I'm on fire today! :) ...

Fri, 29 Feb 2008 07:55:11 +0000

Author: znakeeye
Subject: 9742
Posted: 29 February 2008 at 7:55am

I'm on fire today! :)

pItem->SetBackgroundColor(blue); // Nice...

...until you edit the item!

Default background color should be the same as the one provided in the call to SetBackgroundColor!

The problem lies in here!

HBRUSH CXTPReportInplaceEdit::CtlColor(CDC* pDC, UINT /*nCtlColor*/)
{
pDC->SetTextColor(m_clrText); // Only text color :(

return GetSysColorBrush(COLOR_WINDOW);
}

Possible solution:

HBRUSH CXTPReportInplaceEdit::CtlColor(CDC* pDC, UINT /*nCtlColor*/)
{
pDC->SetTextColor(m_clrText);

pDC->SetBkMode(TRANSPARENT);

return m_bUseItemBackground ? (m_brBackground : GetSysColorBrush(COLOR_WINDOW));
}