Hi Oleg,

 

Thank you very much for your great support and responce.

 

We will surely discuss the issue for using "OnInitCommandBarsPopup()" with our team.

 

Thanks,

KumarCJ.

void CMainFrame::OnInitCommandsPopup(CXTPPopupBar* pCommandBar)
{

  int nCount = pCommandBar->GetControls()->GetCount();

 

 for (int i = 0; i < nCount; i++)
 {

CXTPControl* pCommandNew =  pCommandBar->GetControl(i)
   if (pCommandNew->GetID() == ID_EDIT_CUT)
   {

          pCommandNew->SetEnabled(FALSE);

         pCommandBarNew->SetFlags(xtpFlagManualUpdate);
    }

   }

 }

 

Also check "Samples\CommandBars\ActionsSample" sample - if you don't want update handlers, you can use actions

 

pCommandBars->GetActions()->FindAction(ID_EDIT_CUT)->SetEnabled(FALSE);

 

again - don't use OnInitCommandBarsPopup for changing state - its very bad design. There is no pattern for such design.

 

 

wating for your valuable suggestion.

 

I had mention the issue in code what you sent it to me in prvious post.

 

Please let me know the solution for that.

 

Thanks,

KumarCJ

Thanks for your great suggestion.

When I placed the code what you sent it giving the error below:

 

 

Then I searched for SetEnable() in the help, and I found SetEnabled() in CXTPControl class.

 

 

void CMainFrame::OnInitCommandsPopup(CXTPPopupBar* pCommandBar)
{

   CXTPControl* pCommandNew = pCommandBar->GetControls()->FindControl(xtpControlButton, ID_EDIT_CUT, TRUE, FALSE);
 

//CXTPControl* pCommandNew = pCommandBar->GetControls()->FindControl(xtpControlPopup, ID_EDIT_CUT, TRUE, FALSE);

 int nCount = pCommandBar->GetControls()->GetCount();

 

 for (int i = 0; i < nCount; i++)
 {
   if (pCommandBar->GetControl(i)->GetID() == ID_EDIT_CUT)
   pCommandNew->SetEnabled(FALSE);
   //[Comment out due to error mentioned above]

   //pCommandBar->GetControl(i)->SetEnable(FALSE);
   }

 }

 

What need to be done for this Oleg????

 

Thanks,

KumarCJ

 

 

 

Hi Oleg,

 

Thanks you very much for your seggestions and help.

 

Yes I do understand it is not good idea to implement WM_INITMENUPOPUP, but as we are following design patterns and handling all the enabling/disabling menu item in a single class, which required nIndex, which we were getting in OnInitMenuPopup() function's 2nd parapameter.

 

 

 

 

Hello,

 

This is _very_ bad idea to use WM_INITMENUPOPUP to enable/disable state for some controls. users can customize menu and move Cut Command from one menu to another - to copy this menu to toolbar, delete it etc.

 

as I wrote use Update handlers for IDs:

in message map of your view add:

 

ON_UPDATE_COMMAND_UI(ID_ED_CUT, OnUpdateCut)

 

void CYourView::OnUpdateCut(CCmdUI* pCmdUI)
{
 pCmdUI->Enable(m_bNeedToEnable);
}

 

it will work with your old application/new appliaction and any future applications.

 

Our application follows standard View/Document architecture, We do not have handler for cut,copy,paste and find in our OLDER version of application as well as NEW version of Application.

 

we are just using "ON_WM_INITMENUPOPUP()" message in older version of our application.

 

For above mentioned message we are having Handler

 

 

Do you use standard View/Document architecture? By defaul they have to be disabled if you don't have handlers for them. if you have handlers - just add also Update handlers and enable/disable them in this handler - not in OnInitCommandsPopup.

 

Thanks for your reply.

 

I had trying with the OnInitCommandsPopup() given in Notification sample.

 

I trapped "ON_XTP_INITCOMMANDSPOPUP()" i.e. OnInitCommandsPopup() function.

 

 

   //Get Menu Handle