Codejock Developer Community : Possible Error in XTPCommandBar? http://forum.codejock.com/ Copyright (c) 2006-2013 Web Wiz Forums - All Rights Reserved. Thu, 14 May 2026 04:29:41 +0000 Tue, 13 Feb 2007 07:47:57 +0000 http://blogs.law.harvard.edu/tech/rss Web Wiz Forums 12.04 360 forum.codejock.com/RSS_post_feed.asp?TID=6384 <![CDATA[Codejock Developer Community]]> http://forum.codejock.com/forum_images/codejock-logo.gif http://forum.codejock.com/ <![CDATA[Possible Error in XTPCommandBar? : Hello, When we call it we assume...]]> http://forum.codejock.com/forum_posts.asp?TID=6384&PID=20355&title=possible-error-in-xtpcommandbar#20355 Author: Oleg
Subject: 6384
Posted: 13 February 2007 at 7:47am

Hello,
When we call it we assume toolbar is docked. But agree, that we have add some check for developers how we call this method outside of library. Added ASSERT.
]]> Tue, 13 Feb 2007 07:47:57 +0000 http://forum.codejock.com/forum_posts.asp?TID=6384&PID=20355&title=possible-error-in-xtpcommandbar#20355 <![CDATA[Possible Error in XTPCommandBar? : We&#039;ve recently evaluated...]]> http://forum.codejock.com/forum_posts.asp?TID=6384&PID=20313&title=possible-error-in-xtpcommandbar#20313 Author: skemp@docucorp
Subject: 6384
Posted: 12 February 2007 at 2:26pm

We've recently evaluated a development tool that is supposed to help identify potential programming errors. The following item was found within your framework headers.

Please look at this and let us know what you think.

Buffer overflow, array index of 'm_pDocks' may be outside the bounds. Array 'm_pDocks' of size 4 declared at line 1354 may use index values 4..7

CommandBars\XTPCommandBars.h

1404 AFX_INLINE CXTPDockBar* CXTPCommandBars::GetDockBar(XTPBarPosition xtpPosition) const {

1405 return m_pDocks[xtpPosition];

1406 }

If we examine the m_pDocks declaration, we can see that it is an array of 4 elements.

CommandBars\XTPCommandBars.h

1354 CXTPDockBar* m_pDocks[4]; // DockBars list

If we examine the XTPBarPosition declaration (parameter to GetDockBar), we can see that it is an enum declaration from 0 to 7.

CommandBars\XTPCommandBarsDefines.h

47 enum XTPBarPosition

48 {

49 xtpBarTop = 0, // Docked at top.

50 xtpBarBottom = 1, // Docked at bottom.

51 xtpBarLeft = 2, // Docked at left.

52 xtpBarRight = 3, // Docked at right.

53 xtpBarFloating = 4, // Floated.

54 xtpBarPopup = 5, // Popup.

55 xtpBarListBox = 6, // List box.

56 xtpBarNone = 7 // None.

57 };

Using any of the enum values from 4 to 7 would cause an out of bounds condition on the array.

]]> Mon, 12 Feb 2007 14:26:40 +0000 http://forum.codejock.com/forum_posts.asp?TID=6384&PID=20313&title=possible-error-in-xtpcommandbar#20313