Codejock Developer Community : GetSysColor / SkinFramework (Bug?) http://forum.codejock.com/ Copyright (c) 2006-2013 Web Wiz Forums - All Rights Reserved. Sat, 13 Jun 2026 00:18:08 +0000 Mon, 17 Jul 2006 15:47:51 +0000 http://blogs.law.harvard.edu/tech/rss Web Wiz Forums 12.04 360 forum.codejock.com/RSS_post_feed.asp?TID=4603 <![CDATA[Codejock Developer Community]]> http://forum.codejock.com/forum_images/codejock-logo.gif http://forum.codejock.com/ <![CDATA[GetSysColor / SkinFramework (Bug?) : Hi, easy to fix MFCGridCtrl...]]> http://forum.codejock.com/forum_posts.asp?TID=4603&PID=14198&title=getsyscolor-skinframework-bug#14198 Author: Oleg
Subject: 4603
Posted: 17 July 2006 at 3:47pm

Hi,
 
easy to fix MFCGridCtrl  than disable this  window for SkinFramework :)
 
in void CGridCtrl::OnTimer(UINT nIDEvent)
 
replace

if (nIDEvent != WM_LBUTTONDOWN)

return;

 
to
 

if (nIDEvent != WM_LBUTTONDOWN)

{

CWnd::OnTimer(nIDEvent);

return;

}

]]> Mon, 17 Jul 2006 15:47:51 +0000 http://forum.codejock.com/forum_posts.asp?TID=4603&PID=14198&title=getsyscolor-skinframework-bug#14198 <![CDATA[GetSysColor / SkinFramework (Bug?) : Here is a screenshot of the sheet...]]> http://forum.codejock.com/forum_posts.asp?TID=4603&PID=14197&title=getsyscolor-skinframework-bug#14197 Author: ABuenger
Subject: 4603
Posted: 17 July 2006 at 1:29pm

Here is a screenshot of the sheet with skinning disabled. The Grid calls GetSysColor to get the color for the fixed cells. It's the same with the list control on the left.
 
If I remove the xtpSkinApplyColors flag the list control is drawn correctly, but GetSysColor still return the wrong color.
 
DWORD dwApplyOptions = XTPSkinManager()->GetApplyOptions ();
XTPSkinManager()->SetApplyOptions(dwApplyOptions & ~xtpSkinApplyColors);
 
sheet.DoModal ();
 
XTPSkinManager()->SetApplyOptions(dwApplyOptions);
 
I've also noticed several other bugs with the SkinFramework.
 
The above code causes an assertion in CXTPSkinManagerApiHook::OnHookLoadLibraryA because GetInstance()->GetHookedFunction(xtpSkinApiLoadLibraryA); returns NULL the first time OnHookLoadLibrary is beeing called after disabling skinning / settings apply options.
 
I'm using the popular MFCGridCtrl and if skinning is applied and then a scrollbar arrow pressed the grid only scrolls once but doesn't keep scrolling until the button is released. So you've to click/release, click/release to scroll through the grid.
 
If I disable skinning with XTPSkinManager()->SetAutoApplyNewWindows (FALSE); before showing the sheet and then press the arrow button the grid keeps scrolling but the scrollbar doesn't move.
 
If I don't load a skin everything works correctly, you press an arrow button and the grid start and keeps scrolling whilst the scrollbar moves up or down.
 
 
]]> Mon, 17 Jul 2006 13:29:34 +0000 http://forum.codejock.com/forum_posts.asp?TID=4603&PID=14197&title=getsyscolor-skinframework-bug#14197 <![CDATA[GetSysColor / SkinFramework (Bug?) : Hello, How do you see it? GetSysColor...]]> http://forum.codejock.com/forum_posts.asp?TID=4603&PID=14194&title=getsyscolor-skinframework-bug#14194 Author: Oleg
Subject: 4603
Posted: 17 July 2006 at 12:43pm

Hello,
 
How do you see it? GetSysColor is global function, how skinmanager can determine what window you want to draw?
 
As solution remove xtpSkinApplyColors from ApplyOptions:
 
XTPSkinManager()->SetApplyOptions(xtpSkinApplyMetrics | xtpSkinApplyFrame);
]]> Mon, 17 Jul 2006 12:43:28 +0000 http://forum.codejock.com/forum_posts.asp?TID=4603&PID=14194&title=getsyscolor-skinframework-bug#14194 <![CDATA[GetSysColor / SkinFramework (Bug?) : If skinning is disabled for a...]]> http://forum.codejock.com/forum_posts.asp?TID=4603&PID=14193&title=getsyscolor-skinframework-bug#14193 Author: ABuenger
Subject: 4603
Posted: 17 July 2006 at 10:55am

If skinning is disabled for a window GetSysColor (COLOR_3DFACE) still returns the color the item would get if it's skinned.
 
The hook function should check wheter the window is skinned or not.
 
]]> Mon, 17 Jul 2006 10:55:10 +0000 http://forum.codejock.com/forum_posts.asp?TID=4603&PID=14193&title=getsyscolor-skinframework-bug#14193