ok, I see problem, right Icons collected in array and destroyed in application exit.

you have right idea about destructor things,

but you can delete all controls when popup closed:

 BEGIN_MESSAGE_MAP(CMainFrame, CMDIFrameWnd)
     //{{AFX_MSG_MAP(CMainFrame)
     ON_XTP_UNINITCOMMANDSPOPUP()
     //}}AFX_MSG_MAP
 END_MESSAGE_MAP()
 

void CMainFrame::OnUninitCommandsPopup(CXTPPopupBar* pPopupBar)
{
     // get the list of commands for the popup.
    CXTPControls* pControls = pPopupBar->GetControls();
 }

Any ideas here?  I would like a good solution for this.

I have a temporary solution for this problem but there is still a small issue with my solution.  My solution is to derive a class from the CXTPControlButton and remove the custom icon in its destructor.  I have the following code in the destructor of the derived class:

 // Cleanup the custom icon if it exists
 CXTPImageManager* pImageManager = GetImageManager();
 if (pImageManager != NULL && m_nCustomIconId != 0)
 {
    pImageManager->RemoveIcon(m_nCustomIconId);
 }

Now, when the menu is displayed the custom icons are assigned and copied (internally in CXTPImageManagerIcon::SetIcon).  The next time the menu is clicked I remove all all the CXTPControlButtons in the menu (which deletes them and causes my destructor to be called, deleting the custom icons).  However, this solution keeps the icons allocated between calls to OnCalcDynamicSize.  If, for example, the user clicks the menu only once, then the icons won't be deleted until the window is closed.  In fact, the icons created by the last click of the menu won't be deleted until the window is closed.  (Because OnCalcDynamicSize isn't called again).  So, is there a way to detect when the menu is closing so that I can delete the CXTPControlButtons there and not in the OnCalcDynamicSize call?  I believe that would solve this issue.

..Waiting for a response..

- fishy

yes, it is copied. it will be destroyed automatically in Clear method:

void CXTPImageManagerIconHandle::Clear()
{
 if (m_bClearHandles)
 {
  if (m_hIcon)
  {
   DestroyIcon(m_hIcon);
  }
...

}