Codejock Developer Community : CXTPImageManagerIconHandle copy constructor http://forum.codejock.com/ Copyright (c) 2006-2013 Web Wiz Forums - All Rights Reserved. Tue, 14 Apr 2026 21:59:50 +0000 Wed, 09 Mar 2022 10:17:55 +0000 http://blogs.law.harvard.edu/tech/rss Web Wiz Forums 12.04 360 forum.codejock.com/RSS_post_feed.asp?TID=24273 <![CDATA[Codejock Developer Community]]> http://forum.codejock.com/forum_images/codejock-logo.gif http://forum.codejock.com/ <![CDATA[CXTPImageManagerIconHandle copy constructor : Ok, thanks for the informations.Regards...]]> http://forum.codejock.com/forum_posts.asp?TID=24273&PID=78406&title=cxtpimagemanagericonhandle-copy-constructor#78406 Author: Julianis
Subject: 24273
Posted: 09 March 2022 at 10:17am

Ok, thanks for the informations.

Regards
]]> Wed, 09 Mar 2022 10:17:55 +0000 http://forum.codejock.com/forum_posts.asp?TID=24273&PID=78406&title=cxtpimagemanagericonhandle-copy-constructor#78406 <![CDATA[CXTPImageManagerIconHandle copy constructor : It is definitely a bad design,...]]> http://forum.codejock.com/forum_posts.asp?TID=24273&PID=78405&title=cxtpimagemanagericonhandle-copy-constructor#78405 Author: astoyan
Subject: 24273
Posted: 08 March 2022 at 11:59am

It is definitely a bad design, but it was necessary to do so in order to preserve the backward compatibility with the legacy class implementation that did not support various icon types. Fixing that behavior in constructor will lead to a lot more problems for those who has lots of dependencies on that class for a while.

Regards,
   Alexander
]]> Tue, 08 Mar 2022 11:59:07 +0000 http://forum.codejock.com/forum_posts.asp?TID=24273&PID=78405&title=cxtpimagemanagericonhandle-copy-constructor#78405 <![CDATA[CXTPImageManagerIconHandle copy constructor : We noticed that when using CXTPImageManagerIconHandle,...]]> http://forum.codejock.com/forum_posts.asp?TID=24273&PID=78402&title=cxtpimagemanagericonhandle-copy-constructor#78402 Author: Julianis
Subject: 24273
Posted: 22 February 2022 at 10:36am

We noticed that when using CXTPImageManagerIconHandle, the copy constructor doesnt duplicate the handles when copying from a non shared handle:

CXTPImageManagerIconHandle A;

// loads a HBITMAP in A, A.m_bClearHandles set to TRUE
A.CreateIconFromResource(MAKEINTRESOURCE(ID_XXXX), CSize(32, 32));

// copy constructor, members are simply copied, so handle from A ends up in B
// but B.m_bClearHandles = FALSE
CXTPImageManagerIconHandle  B(A);

// frees up handle
A.Clear();

// at this stage B still reference an invalid HBITMAP


I just modifed the copy constructor to call CopyHandle() if (hHandle.m_bClearHandles == TRUE)


Is it a bug or is there a design issue i missed ?

Regards
]]> Tue, 22 Feb 2022 10:36:53 +0000 http://forum.codejock.com/forum_posts.asp?TID=24273&PID=78402&title=cxtpimagemanagericonhandle-copy-constructor#78402