Codejock Developer Community : DPI awareness for icons in Ribbon

DPI awareness for icons in Ribbon : markr wrote:>But, can't...

Sat, 17 Jun 2017 15:34:50 +0000

Author: olebed
Subject: 23038
Posted: 17 June 2017 at 3:34pm

markr wrote:

> But, can't we get the closest icon size in the resources, without scaling it?

That's what I'd like to know as well.

Scaling will almost always result in a lower quality experience when compared to simply choosing the closest fit (without scaling).

- Mark R.

Hello,

The scaling of Ribbon icons have been fixed. Also some samples updated. Fix will be available soon in next release.

As I wrote icons will be scaled only if option IsDPIIconsScallingEnabled() is TRUE or size of icon is bigger than button.

Regards,
Oleksandr Lebed

DPI awareness for icons in Ribbon : Hello Frederik,Logic of option...

Mon, 12 Jun 2017 16:05:02 +0000

Author: olebed
Subject: 23038
Posted: 12 June 2017 at 4:05pm

Hello Frederik,

Logic of option 'm_bAutoResizeIcons == TRUE' - calculate best size of normal and large icons for current font size (Size of Ribbon depend on font size). Also current font depend on current DPI so m_bAutoResizeIcons also gives resizing for HighDPI.

That is why I think IsDPIIconsScallingEnabled is redundant. Also using these two options (TRUE) together give awful result. But there are cases where customers don't want use many icon sets for different DPI and they need this icon's scaling. So I'm going to change appointment of IsDPIIconsScallingEnabled(pButton) - allow any icon scaling only if it is TRUE else - will be used only original size of icons, except icon is bigger than button/control.

Now I fix using IsDPIIconsScallingEnabled() in CXTPPaintManager::DrawControlToolBarParent /*case as on your screenshot*/ and going to add it in other places (drawing Combobox, Edit control, some themes (CXTPCommandBarsOffice2000Theme, CXTPCommandBarsOfficeXPTheme)

Regards,
Oleksandr Lebed

DPI awareness for icons in Ribbon : ... this is the result of calling...

Mon, 12 Jun 2017 04:49:33 +0000

Author: Fredrik
Subject: 23038
Posted: 12 June 2017 at 4:49am

... this is the result of calling SetDPIScallingOptions(TRUE, TRUE) and using m_bAutoResizeIcons = TRUE:

Thought they would be independent of each other? The reason I tried was just to see whether it is possible to get auto resized icons in backstage in v18 - it seems to be broken - or at least the behaviour has changed between 17 and 18.

DPI awareness for icons in Ribbon : Hello,Fix for icon's scaling...

Fri, 09 Jun 2017 05:41:20 +0000

Author: olebed
Subject: 23038
Posted: 09 June 2017 at 5:41am

Hello,
Fix for icon's scaling for Ribbon's buttons with style xtpButtonIconAndCaptionBelow and when set some value for pCommandBars->m_pOptions->szLargeIcons

in Source\CommandBars\XTPPaintManager.cpp

CSize CXTPPaintManager::GetIconSize(CXTPControl* pButton){
    XTPButtonStyle buttonStyle = pButton->GetStyle();

    CSize szIcon = buttonStyle == xtpButtonIconAndCaptionBelow
        && pButton->GetParent()->GetType() != xtpBarTypePopup ?
        pButton->GetParent()->GetLargeIconSize(/**/ m_bAutoResizeIcons /*/ TRUE /**/) : pButton->GetIconSize();

    return szIcon;
}

Regards,
Oleksandr Lebed

DPI awareness for icons in Ribbon : >But, can't we get the...

Thu, 04 May 2017 13:11:16 +0000

Author: markr
Subject: 23038
Posted: 04 May 2017 at 1:11pm

> But, can't we get the closest icon size in the resources, without scaling it?

That's what I'd like to know as well.

Scaling will almost always result in a lower quality experience when compared to simply choosing the closest fit (without scaling).

- Mark R.

DPI awareness for icons in Ribbon : But, can't we get the closest...

Sat, 14 Jan 2017 13:30:41 +0000

Author: cpede
Subject: 23038
Posted: 14 January 2017 at 1:30pm

But, can't we get the closest icon size in the resources, without scaling it?

-cpede

DPI awareness for icons in Ribbon : Hello Mark,In your case algorithm...

Fri, 13 Jan 2017 16:23:26 +0000

Author: olebed
Subject: 23038
Posted: 13 January 2017 at 4:23pm

Hello Mark,

In your case algorithm needs 56x56 icons and take nearest exist 48x48 then scale they to 56x56.

You can see what exactly size is needed in method CXTPPaintManager::GetAutoIconSize.

On my virtual test machine Win7 with 125 % DPI GetControlHeight() returns 29, then

int nHeight = GetControlHeight() - XTP_DPI_Y(4); // 29 - 5 = 24

then for small icons we get 24x24 and for large 48x48

100%: 23 - XTP_DPI_Y(4) -> 23 - 4 = 19 -> 16x16 and 32x32

120%: 27 - XTP_DPI_Y(4) -> 27 - 5 = 22 -> 16x16 and 40x40

125%: 29 - XTP_DPI_Y(4) -> 29 - 5 = 24 -> 24x24 and 48x48

135%: 31 - XTP_DPI_Y(4) -> 31 - 5 = 26 -> 24x24 and 48x48

150%: 35 - XTP_DPI_Y(4) -> 35 - 6 = 29 -> 24x24 and 56x56

175%: 41 - XTP_DPI_Y(4) -> 41 - 7 = 34 -> 32x32 and 64x64

200%: 47 - XTP_DPI_Y(4) -> 47 - 8 = 39 -> 32x32 and 72x72

Regards,
Oleksandr Lebed

DPI awareness for icons in Ribbon : Any thoughts on this? Am I doing...

Thu, 12 Jan 2017 11:46:19 +0000

Author: markr
Subject: 23038
Posted: 12 January 2017 at 11:46am

Any thoughts on this? Am I doing something wrong?

- Mark R.

DPI awareness for icons in Ribbon : Hello Lebed,I've been running...

Wed, 07 Dec 2016 13:32:08 +0000

Author: markr
Subject: 23038
Posted: 07 December 2016 at 1:32pm

Hello Lebed,

I've been running some tests based on the information you provided above, and I'm not quite getting the results I expect.

For my test, I took one application toolbar which normally has icon sizes of 32x32 and attempted to add support for 125% and 150% DPI scaling. So I created two new icon sets - one for 125% scaling (40x40) and another for 150% scaling (48x48).

The command bars are created within a dialog window:

	m_pCommandBars = (CXTPCommandBars*)CXTPCommandBars::CreateObject();
	m_pCommandBars->GetPaintManager()->m_bAutoResizeIcons = TRUE;
	m_pCommandBars->GetCommandBarsOptions()->SetDPIScallingOptions(TRUE, FALSE);
	m_pCommandBars->SetSite(this);

And the toolbar icons are set:

	VERIFY(XTPImageManager()->SetIcons(IDB_PNG_SEARCH_32, nIDs, ARRAYSIZE(nIDs), CSize(32, 32)));
	VERIFY(XTPImageManager()->SetIcons(IDB_PNG_SEARCH_40, nIDs, ARRAYSIZE(nIDs), CSize(40, 40)));
	VERIFY(XTPImageManager()->SetIcons(IDB_PNG_SEARCH_48, nIDs, ARRAYSIZE(nIDs), CSize(48, 48)));

The results of this test:

Set display to 100% (normal) scaling, and the toolbar shows the 32x32 icons [expected]
Set display to 125% scaling, and the toolbar shows the 40x40 icons [expected]
Set display to 150% scaling, and toolbar display seems to be incorrect. The resulting images are slightly malformed.

Here's how the 48x48 icons appear in my toolbar (notice how they are jagged):

Am I doing something incorrectly, or are my operating assumptions somehow incorrect?

Thanks again for your time on this.

- Mark R.

DPI awareness for icons in Ribbon : Hello Mark,I did this with test...

Tue, 06 Dec 2016 11:25:51 +0000

Author: olebed
Subject: 23038
Posted: 06 December 2016 at 11:25am

Hello Mark,

I did this with test icon set. For RibbonSample I need set of nice Office icons for all sizes.
I will try to do this because sample really is not looking very good now