Codejock Developer Community : CXTPButton images on high dpi http://forum.codejock.com/ Copyright (c) 2006-2013 Web Wiz Forums - All Rights Reserved. Sun, 19 Apr 2026 14:21:58 +0000 Fri, 27 Jan 2017 09:36:01 +0000 http://blogs.law.harvard.edu/tech/rss Web Wiz Forums 12.04 360 forum.codejock.com/RSS_post_feed.asp?TID=22732 <![CDATA[Codejock Developer Community]]> http://forum.codejock.com/forum_images/codejock-logo.gif http://forum.codejock.com/ <![CDATA[CXTPButton images on high dpi : Yes, please fix the CXTPButton...]]> http://forum.codejock.com/forum_posts.asp?TID=22732&PID=75523&title=cxtpbutton-images-on-high-dpi#75523 Author: cpede
Subject: 22732
Posted: 27 January 2017 at 9:36am

Yes, please fix the CXTPButton images with high DPI.

-cpede
]]> Fri, 27 Jan 2017 09:36:01 +0000 http://forum.codejock.com/forum_posts.asp?TID=22732&PID=75523&title=cxtpbutton-images-on-high-dpi#75523 <![CDATA[CXTPButton images on high dpi : CXTPButton have the same problem...]]> http://forum.codejock.com/forum_posts.asp?TID=22732&PID=75496&title=cxtpbutton-images-on-high-dpi#75496 Author: evoX
Subject: 22732
Posted: 15 January 2017 at 4:22pm

CXTPButton have the same problem :(
Images are scaled very badly on larger DPI and button text remain small and is not scaled up.
Even if I specify a larger icon for the button, it still gets scaled and messed up. Is there a way to disable the image scaling on CXTPButton ? And enlarge the button text font?


]]> Sun, 15 Jan 2017 16:22:33 +0000 http://forum.codejock.com/forum_posts.asp?TID=22732&PID=75496&title=cxtpbutton-images-on-high-dpi#75496 <![CDATA[CXTPButton images on high dpi : I&#039;ve just downloaded codejock...]]> http://forum.codejock.com/forum_posts.asp?TID=22732&PID=74489&title=cxtpbutton-images-on-high-dpi#74489 Author: JamesP
Subject: 22732
Posted: 22 February 2016 at 12:57pm

I've just downloaded codejock version 17.1 and am currently testing it and going through all the high dpi issues I found with the Beta 3.

1) The CXTPCheckListBox is still not considering the correct rect when clicking on and invalidating it. I've changed my solution so the constructor of the m_checkListState member wraps the m_sizeCheck variable in the XTP_DPI macro:

     m_sizeCheck.cx = XTP_DPI_X(bm.bmWidth / 3);
     m_sizeCheck.cy = XTP_DPI_Y(bm.bmHeight);


2) Large toolbars still aren't showing the correct size icon. We're still having to apply the XTP_DPI macro to the size passed to the SetIconSize function in the CXTPToolBar LoadToolBar function.


3) The issue with the CXTPRibbonBackstageViewThemeResource simply scaling up small icons has now been fixed. Thanks.


4) Some of the Codejock controls, like radio buttons, slider controls and scroll bars on gallery controls are still quite badly pixelated at high DPI.


5) As you already noted, you did not implement my CXTPControlBitmap::GetSize fix, stating that it "changes default behavior for the function and thus most likely other customers will complain about broken behavior in their scenarios." It is still a necessary fix for us to enable us to show the best size image for the dpi.


6) There is still an issue with gallery control items showing icon sizes that best fit the dpi. The existing code just displays the smallest icon using CXTPControlGalleryItem::GetImage() function. I've had to change this function to take a boolean parameter, and change the CXTPControlGalleryPaintManager DrawItem function to intially find the smallest icon, to work out drawing extents, and then just before drawing, finds the best icon to draw. So the code inside the CXTPControlGalleryItem GetImage function now looks like this:

CXTPImageManagerIcon* CXTPControlGalleryItem::GetImage(bool bSmall)
{
    if (!m_pItems)
      return NULL;

    return m_pItems->GetImageManager()->GetImage(m_nImage >= 0 ? m_nImage : m_nId, (bSmall == true) ? 0 : m_nImageWidth);
}

and the CXTPControlGalleryPaintManager DrawItem function now looks something like:

void CXTPControlGalleryPaintManager::DrawItem(...)
{
    ...
    CXTPImageManagerIcon* pImage = pGalleryItem->GetImage(true);
    ...
    if (...)
    {
      ...
      if (pImage = pGalleryItem->GetImage(false))
        pImage->Draw(...);
      ...
    }
    else if (...)
    {
      ...
      if (pImage = pGalleryItem->GetImage(false))
        pImage->Draw(...);
      ...
    }
    else if (...)
    {
      ...
      if (pImage = pGalleryItem->GetImage(false))
        pImage->Draw(...);
    }
    ...
}

For this to have any effect, larger images must be supplied and gallery items must call SetImageWidth, with the smallest icon width wrapped in the XTP_DPI_X macro. Excuse me if my previous explanation of the problem and my solution weren't clear enough.


7) The issue I was having with providing larger icon sets for ribbon bar items, messing up the ribbon layout has now been fixed. Thankyou.


8) The issue with right-click context menus always showing the smallest icon has not been fixed. I appreciate you could not implement our fix, but we will continue to use it, as it hasn't caused any unexpected results for us or our customers.


9) The issue we found with icons on the Status Bar simply scaling up the smallest icon provided, also has not been fixed. I trust you are looking into this and we will continue to use our fix.


10) The inital problem we found with icons on buttons simply scaling up the smallest size provided is still an issue. We will continue to remove the XTP_DPI macro from calls to pButton->GetImageSize() in both the CXTPButtonTheme and CXTPButtonThemeOffice2013 classes.


In addition to this, the new version appears to badly clip tooltip text. I don't know if you're aware of this. It may be expecting a small size image when calculating the tooltip rect and then when it displays the tooltip, it uses the largest image and doesn't have enough room to display the text. I'll look into it further.            ]]> Mon, 22 Feb 2016 12:57:49 +0000 http://forum.codejock.com/forum_posts.asp?TID=22732&PID=74489&title=cxtpbutton-images-on-high-dpi#74489 <![CDATA[CXTPButton images on high dpi : I&#039;ve just found an issue...]]> http://forum.codejock.com/forum_posts.asp?TID=22732&PID=74156&title=cxtpbutton-images-on-high-dpi#74156 Author: JamesP
Subject: 22732
Posted: 01 December 2015 at 5:54am

I've just found an issue with the CXTPCheckListBox class. The hit test rect for the check box appears to be incorrect as does the invalidation rect.

To fix this I made a changes to the CXTPCheckListBox, InvalidateCheck and OnLButtonDown functions, wrapping the m_checkListState.m_sizeCheck.cx parameters in the XTP_DPI_X macro.]]> Tue, 01 Dec 2015 05:54:22 +0000 http://forum.codejock.com/forum_posts.asp?TID=22732&PID=74156&title=cxtpbutton-images-on-high-dpi#74156 <![CDATA[CXTPButton images on high dpi : I&#039;ve just had to make another...]]> http://forum.codejock.com/forum_posts.asp?TID=22732&PID=74112&title=cxtpbutton-images-on-high-dpi#74112 Author: JamesP
Subject: 22732
Posted: 17 November 2015 at 1:00pm

I've just had to make another fix for toolbars we have in our applications that are non standard sizes. In these instances it's displaying the smallest icon rather than the one that best fits the dpi setting.

Towards the end of the LoadToolBar function in the CXTPCommandBar class there's a line of code:

if (pData->wWidth != 16)
{
        SetIconSize(CSize(pData->wWidth, pData->wHeight));
}

To get it to work correctly I've wrapped the CSize in the XTP_DPI macro, giving me:

{
        SetIconSize(XTP_DPI(CSize(pData->wWidth, pData->wHeight)));
}

]]> Tue, 17 Nov 2015 13:00:50 +0000 http://forum.codejock.com/forum_posts.asp?TID=22732&PID=74112&title=cxtpbutton-images-on-high-dpi#74112 <![CDATA[CXTPButton images on high dpi : I&#039;d really appreciate it...]]> http://forum.codejock.com/forum_posts.asp?TID=22732&PID=74082&title=cxtpbutton-images-on-high-dpi#74082 Author: JamesP
Subject: 22732
Posted: 02 November 2015 at 1:41pm

I'd really appreciate it if you could give me some idea of when the final release is due, as it would help us with scheduling our development.

I've had a look at other forum posts but can't see any mention of it anywhere. I seem to recall reading it was due sometime in October.

Thanks]]> Mon, 02 Nov 2015 13:41:55 +0000 http://forum.codejock.com/forum_posts.asp?TID=22732&PID=74082&title=cxtpbutton-images-on-high-dpi#74082 <![CDATA[CXTPButton images on high dpi : Thanks for getting back to me....]]> http://forum.codejock.com/forum_posts.asp?TID=22732&PID=74075&title=cxtpbutton-images-on-high-dpi#74075 Author: JamesP
Subject: 22732
Posted: 30 October 2015 at 2:51pm

Thanks for getting back to me. I've been a bit too busy getting our suite of applications ready but will respond when I have a few minutes.

We are looking to release our software shortly, maybe mid to late November, and we wondered what your schedule is for the final Version 17 release.

Thanks,
James]]> Fri, 30 Oct 2015 14:51:32 +0000 http://forum.codejock.com/forum_posts.asp?TID=22732&PID=74075&title=cxtpbutton-images-on-high-dpi#74075 <![CDATA[CXTPButton images on high dpi : Hello JamesP,Thank you for applying...]]> http://forum.codejock.com/forum_posts.asp?TID=22732&PID=74041&title=cxtpbutton-images-on-high-dpi#74041 Author: astoyan
Subject: 22732
Posted: 18 October 2015 at 4:15pm

Hello JamesP,

Thank you for applying so much efforts sharing your work, we appreciate it. We are aware about all these and other similar issues, the biggest challenge for us is to add DPI support to controls that have not been initially designed for anything like that and make sure we don't break any backward compatibility in most common scenarios, this is why in some cases the solutions don't seem perfect, but at least they satisfy the majority.

Your fixes have been reviewed, here is the report:
1. The CXTPStatusBarPane::GetImage fix looks like it can introduce issues in other scenarios when a wide item is used with a large image available. It'll be reviewed futher.
2. Unfortunately CXTPCommandbar::GetIconSize is already used in may places inappropriately and the provided fix will break many unexpected places in different scenarios.
3. The CXTPControlGalleryItem::GetImage fix. It looks like you always call GetImage(false) which makes no difference and the code works just like before.
4. The CXTPControlBitmap::GetSize fix changes default behavior for the function and thus most likely other customers will complain about broken behavior in their scenarios.
5. The GetAutoIconSize and CXTPRibbonBackstageViewThemeResource fixes have been verified and included.

Thank you.
Regards,
  Alexander
]]> Sun, 18 Oct 2015 16:15:55 +0000 http://forum.codejock.com/forum_posts.asp?TID=22732&PID=74041&title=cxtpbutton-images-on-high-dpi#74041 <![CDATA[CXTPButton images on high dpi : Glad to help Mark. It&#039;s partly...]]> http://forum.codejock.com/forum_posts.asp?TID=22732&PID=74038&title=cxtpbutton-images-on-high-dpi#74038 Author: JamesP
Subject: 22732
Posted: 15 October 2015 at 11:34am

Glad to help Mark. It's partly for my own reference as I expect to have to go through this whole process again when 17.0 is released.

I've found another issue. In the ribbon bar system button, the icons that appear here are simply small icons, scaled up. To fix it I've changed the DrawControl function in the CXTPRibbonBackstageViewThemeResource class.

The code that looks like the following

CXTPImageManagerIcon* pIcon = pView->GetImageManager()->GetImage(pControl->GetIconId());
if (pIcon)
{
    // Office 2010 respects this rule of 120 DPI
    ...
}

I've changed to:

CXTPImageManagerIcon* pSmallIcon = pView->GetImageManager()->GetImage(pControl->GetIconId(), ICON_SMALL);
if (pSmallIcon)
{
    // Office 2010 respects this rule of 120 DPI
    CSize szIconScalled(XTPDpiHelper()->ScaleX(pSmallIcon->GetWidth(), 120), XTPDpiHelper()->ScaleY(pSmallIcon->GetHeight(), 120));

    CPoint ptIcon = CPoint(rcText.left, (rcText.top + rcText.bottom - szIconScalled.cy ) / 2);

    if (auto pBestIcon = pView->GetImageManager()->GetImage(pControl->GetIconId(), szIconScalled.cx))
        pBestIcon->Draw(pDC, ptIcon, pBestIcon->GetIcon(bEnabled ? xtpImageNormal : xtpImageDisabled), szIconScalled);

    rcText.left += XTPDpiHelper()->ScaleX(pSmallIcon->GetWidth(), 120) + m_nImageMargin;
}           ]]> Thu, 15 Oct 2015 11:34:58 +0000 http://forum.codejock.com/forum_posts.asp?TID=22732&PID=74038&title=cxtpbutton-images-on-high-dpi#74038 <![CDATA[CXTPButton images on high dpi : James, thanks for taking the time...]]> http://forum.codejock.com/forum_posts.asp?TID=22732&PID=74029&title=cxtpbutton-images-on-high-dpi#74029 Author: markr
Subject: 22732
Posted: 14 October 2015 at 1:06pm

James, thanks for taking the time to post all of this information. Should prove useful to those of us about to undertake a similar process.

- Mark R.
]]> Wed, 14 Oct 2015 13:06:22 +0000 http://forum.codejock.com/forum_posts.asp?TID=22732&PID=74029&title=cxtpbutton-images-on-high-dpi#74029