[not bug] Report Control MoveRecord bug : Hi Jorge,Logic of MoveRecord(nIndex,...

Mon, 29 Jun 2015 15:55:18 +0000

Author: olebed
Subject: 22644
Posted: 29 June 2015 at 3:55pm

Hi Jorge,

Logic of MoveRecord(nIndex, pRecord) is move pRecord to place BEFORE record with index nIndex. We follow this logic in other places in code, and we are not going to change MoveRecord().

If you delete those two conditions then method will work incorrect.

If nIndex is greater than index of pRecord
	then pRecord will be placed AFTER record with nIndex
else 
	then pRecord will be placed BEFORE record with nIndex

Regards,
Oleksandr Lebed

[not bug] Report Control MoveRecord bug : I think there is a bug on MoveRecord()...

Mon, 29 Jun 2015 14:35:54 +0000

Author: jmarcosf
Subject: 22644
Posted: 29 June 2015 at 2:35pm

I think there is a bug on MoveRecord() method on CXTPReportRecords class.
I commented out on source code below.

void CXTPReportRecords::MoveRecord(int nIndex, CXTPReportRecord* pRecord, BOOL bUpdateIndexes)
{
     if (nIndex < 0)
          nIndex = 0;

     if (nIndex > GetCount())
          nIndex = GetCount();

     if (pRecord)
     {
          int nRecordIndex = pRecord->GetIndex();

          if (nRecordIndex == nIndex)
               return;

          if (GetAt(nRecordIndex) == pRecord)
          {
               if (nRecordIndex < nIndex)          // I think this two sentences
                    nIndex--;                                // do not allow to move any record
                                                                   // one line down
               if (nRecordIndex == nIndex)       // Maybe I am wrong but
                    return;                                   // removing them it works fine for me
                                                                  // when I call it with index = current record index + 1
               m_arrRecords.RemoveAt(nRecordIndex);
               m_arrRecords.InsertAt(nIndex, pRecord);

               if (bUpdateIndexes)
                    UpdateIndexes();
          }
     }
}

Codejock Developer Community : [not bug] Report Control MoveRecord bug

[not bug] Report Control MoveRecord bug : Hi Jorge,Logic of MoveRecord(nIndex,...

[not bug] Report Control MoveRecord bug : I think there is a bug on MoveRecord()...