Codejock Developer Community : Several bugs in grouped control http://forum.codejock.com/ Copyright (c) 2006-2013 Web Wiz Forums - All Rights Reserved. Thu, 04 Jun 2026 04:41:35 +0000 Sun, 24 Jan 2016 15:19:25 +0000 http://blogs.law.harvard.edu/tech/rss Web Wiz Forums 12.04 360 forum.codejock.com/RSS_post_feed.asp?TID=22579 <![CDATA[Codejock Developer Community]]> http://forum.codejock.com/forum_images/codejock-logo.gif http://forum.codejock.com/ <![CDATA[Several bugs in grouped control : We delete flagged records on a...]]> http://forum.codejock.com/forum_posts.asp?TID=22579&PID=74368&title=several-bugs-in-grouped-control#74368 Author: adrien
Subject: 22579
Posted: 24 January 2016 at 3:19pm

We delete flagged records on a timer, so not deleting selected rows at all.  This is so dead records can hang around for a while before disappearing so that fast adds and deletes still are visible.  I don't believe this is contributing to the problem though.

We call RemoveRecordEx

RemoveRowEx just calls through to that anyway.

I've looked through the CJ source on this, and it's not clear yet why it's happening.  It looks to delete row objects when you remove a record, so you'd think the other unaffected rows would keep the selected attribute (actually there is none, this is stored in a separate array of pointers to row objects).

It only affects selected rows below the deleted row.

It's like there's another array of rows that is just used for drawing, and that is the one that keeps the flag that makes it draw with the blue background.

I never tried this on 16.x, maybe it wasn't broken in that version.

]]> Sun, 24 Jan 2016 15:19:25 +0000 http://forum.codejock.com/forum_posts.asp?TID=22579&PID=74368&title=several-bugs-in-grouped-control#74368 <![CDATA[Several bugs in grouped control : How are you deleting a non-selected...]]> http://forum.codejock.com/forum_posts.asp?TID=22579&PID=74353&title=several-bugs-in-grouped-control#74353 Author: Algae
Subject: 22579
Posted: 21 January 2016 at 9:49pm

How are you deleting a non-selected row? I tried with a multi-user system where a row is deleted by another user. In my test, it retained the group selection on the other user's list correctly.

I probably use a process similar to yours. I track the index of the deleted row(s), however. I also test to see if the row has an associated record. I believe group rows do not.

Example in "delete" method:

    CXTPReportSelectedRows* pSelectedRows = GetReportCtrl().GetSelectedRows();

// make sure pSelectedRows exists... then do this:

    INT_PTR rowCount = pSelectedRows->GetCount();

        while (rowCount--)
        {
            POSITION pos = pSelectedRows->GetFirstSelectedRowPosition();

            pRow = pSelectedRows->GetNextSelectedRow(pos);

            if (!pRow || !pRow->GetRecord())
                continue;

            // get marker for scroll position
            index = pRow->GetIndex();

            VERIFY(GetReportCtrl().RemoveRowEx(pRow, FALSE));
        };

        // move selection to next row if possible

        pRow = GetReportCtrl().GetRows()->GetAt(index);
        if ( pRow )
            GetReportCtrl().SetFocusedRow(pRow);

        GetReportCtrl().AdjustScrollBars();
        GetReportCtrl().RedrawControl();

*this is using v. 16.26. I'm still hacking away at 17 so haven't tried that yet. With any luck, this may offer you a solution.
]]> Thu, 21 Jan 2016 21:49:47 +0000 http://forum.codejock.com/forum_posts.asp?TID=22579&PID=74353&title=several-bugs-in-grouped-control#74353 <![CDATA[Several bugs in grouped control : Hi. This is still a problem in...]]> http://forum.codejock.com/forum_posts.asp?TID=22579&PID=74352&title=several-bugs-in-grouped-control#74352 Author: adrien
Subject: 22579
Posted: 21 January 2016 at 9:12pm

Hi.  This is still a problem in 17, and I don't think it can be adequately fixed by me manually adjusting selected rows on every delete.

the problem is that we use grouping.  If a group header row is selected, then a row above that is deleted, then the group header row is no longer selected, instead it's the first child row.

Since we don't have any record associated with the header row, we have nowhere to store the selected state, so no way to reinstate the correct state.

You guys really should just fix this, when a row is moved by deletion of a row above, the selection state of the row should move with it.  If a group header row moves location, so should its selection state.  Doing this afterwards is going to be buggy, and non-performant.
]]> Thu, 21 Jan 2016 21:12:46 +0000 http://forum.codejock.com/forum_posts.asp?TID=22579&PID=74352&title=several-bugs-in-grouped-control#74352 <![CDATA[Several bugs in grouped control : actually ignore that comment about...]]> http://forum.codejock.com/forum_posts.asp?TID=22579&PID=73653&title=several-bugs-in-grouped-control#73653 Author: adrien
Subject: 22579
Posted: 16 July 2015 at 6:47pm

actually ignore that comment about key up.]]> Thu, 16 Jul 2015 18:47:39 +0000 http://forum.codejock.com/forum_posts.asp?TID=22579&PID=73653&title=several-bugs-in-grouped-control#73653 <![CDATA[Several bugs in grouped control : what it looks like, is that you...]]> http://forum.codejock.com/forum_posts.asp?TID=22579&PID=73652&title=several-bugs-in-grouped-control#73652 Author: adrien
Subject: 22579
Posted: 16 July 2015 at 6:45pm

what it looks like, is that you attach the bSelected flag to the ROW rather than the RECORD, and you re-assign records to different rows when records are added and deleted without updating this flag.

Adrien
]]> Thu, 16 Jul 2015 18:45:31 +0000 http://forum.codejock.com/forum_posts.asp?TID=22579&PID=73652&title=several-bugs-in-grouped-control#73652 <![CDATA[Several bugs in grouped control : p.s. it still seems to know where...]]> http://forum.codejock.com/forum_posts.asp?TID=22579&PID=73651&title=several-bugs-in-grouped-control#73651 Author: adrien
Subject: 22579
Posted: 16 July 2015 at 6:42pm

p.s. it still seems to know where the cursor is, because when I arrow up, it comes up from the place where the blue selection should have been.

This problem occurs on both insert and delete
]]> Thu, 16 Jul 2015 18:42:34 +0000 http://forum.codejock.com/forum_posts.asp?TID=22579&PID=73651&title=several-bugs-in-grouped-control#73651 <![CDATA[Several bugs in grouped control : HIfor insert we use ReportControl...]]> http://forum.codejock.com/forum_posts.asp?TID=22579&PID=73650&title=several-bugs-in-grouped-control#73650 Author: adrien
Subject: 22579
Posted: 16 July 2015 at 6:40pm

HI

for insert we use ReportControl methods

BeginUpdate();
AddRecordEx(pRecord);
EndUpdate();
AdjustScrollBars();

for delete we do

BeginUpdate();
RemoveRecordEx(pRecord, TRUE);
EndUpdate();
AdjustScrollBars();

Adrien

]]> Thu, 16 Jul 2015 18:40:50 +0000 http://forum.codejock.com/forum_posts.asp?TID=22579&PID=73650&title=several-bugs-in-grouped-control#73650 <![CDATA[Several bugs in grouped control : Hi adrien,What code do you use...]]> http://forum.codejock.com/forum_posts.asp?TID=22579&PID=73648&title=several-bugs-in-grouped-control#73648 Author: olebed
Subject: 22579
Posted: 16 July 2015 at 4:52pm

Hi adrien,

What code do you use to reproduce this behavior ?

CXTPReportRecords::Add, RemoveAt, RemoveRecord, InsertAt  and other don't take into account selected rows. To keep selection you need to reselect. For example see using CXTPReportControl::m_bKeepSelectionAfterSort in CXTPReportHeader::OnLButtonUp() method.
]]> Thu, 16 Jul 2015 16:52:27 +0000 http://forum.codejock.com/forum_posts.asp?TID=22579&PID=73648&title=several-bugs-in-grouped-control#73648 <![CDATA[Several bugs in grouped control : Hi OleksandrI just installed 17...]]> http://forum.codejock.com/forum_posts.asp?TID=22579&PID=73646&title=several-bugs-in-grouped-control#73646 Author: adrien
Subject: 22579
Posted: 16 July 2015 at 2:48pm

Hi Oleksandr

I just installed 17 beta 1 and recompiled all our code for it.  The report control is a great deal better, but there is still 1 bug I can see.

If you have a row selected, then insert or delete a row above this selected row, then the blue selection shifts to a different record.  More precisely, the blue selection row stays visually at the same screen location while the records move underneath, so the selected record appears to be different.

Keyboard navigation is a LOT better, thanks!

Thanks

Adrien 
]]> Thu, 16 Jul 2015 14:48:49 +0000 http://forum.codejock.com/forum_posts.asp?TID=22579&PID=73646&title=several-bugs-in-grouped-control#73646 <![CDATA[Several bugs in grouped control : Hi Oleksandrthanks for that, I&#039;ll...]]> http://forum.codejock.com/forum_posts.asp?TID=22579&PID=73546&title=several-bugs-in-grouped-control#73546 Author: adrien
Subject: 22579
Posted: 24 June 2015 at 6:11am

Hi Oleksandr

thanks for that, I'll be sure to let you know.

Regards

Adrien
]]> Wed, 24 Jun 2015 06:11:24 +0000 http://forum.codejock.com/forum_posts.asp?TID=22579&PID=73546&title=several-bugs-in-grouped-control#73546