Codejock Developer Community : CXTPCommandBarsSiteBase memory leak

CXTPCommandBarsSiteBase memory leak : Excellent

Sun, 18 Oct 2009 04:42:58 +0000

Author: terrym
Subject: 15381
Posted: 18 October 2009 at 4:42am

Excellent

CXTPCommandBarsSiteBase memory leak : yes, sure.

Sun, 18 Oct 2009 01:27:26 +0000

Author: Oleg
Subject: 15381
Posted: 18 October 2009 at 1:27am

yes, sure.

CXTPCommandBarsSiteBase memory leak : Did this make fix for 13.2?

Fri, 16 Oct 2009 07:50:56 +0000

Author: terrym
Subject: 15381
Posted: 16 October 2009 at 7:50am

Did this make fix for 13.2?

CXTPCommandBarsSiteBase memory leak : Hi, Thanks, indeed we didn't...

Fri, 16 Oct 2009 05:23:33 +0000

Author: Oleg
Subject: 15381
Posted: 16 October 2009 at 5:23am

Hi,

Thanks, indeed we didn't catch such scenario. I will add same fix code.

Thanks.

CXTPCommandBarsSiteBase memory leak : Hmmm, why not destroy the command-bar...

Fri, 16 Oct 2009 05:07:04 +0000

Author: znakeeye
Subject: 15381
Posted: 16 October 2009 at 5:07am

Hmmm, why not destroy the command-bar in OnDestroy()?

CXTPCommandBarsSiteBase memory leak : XTP 12.0.1, but I think this...

Fri, 16 Oct 2009 05:04:09 +0000

Author: znakeeye
Subject: 15381
Posted: 16 October 2009 at 5:04am

XTP 12.0.1, but I think this is present in all versions.

class CMyPane : public CXTPFrameWndBase<CWnd>

...

int CMyPane::OnCreate(LPCREATESTRUCT lpCreateStruct)

{

if (CXTPFrameWndBase<CWnd>::OnCreate(lpCreateStruct) == -1)

return -1;

InitCommandBars();

...

}

In my application this window is created, destroyed and then created again - without destroying the CMyPane-object:

m_myPane.Destroy();

...

m_myPane.Create(...); // MEMORY LEAK!

The error lies in XTPFrameWnd.h. Obviously, you don't think about the above scenario!

virtual BOOL InitCommandBars(CRuntimeClass* pCommandBarsClass = RUNTIME_CLASS(CXTPCommandBars))
{

// Begin FIX

    if (m_pCommandBars)
    {
        m_pCommandBars->InternalRelease();
    }

    // End FIX
    ASSERT(pCommandBarsClass->IsDerivedFrom(RUNTIME_CLASS(CXTPCommandBars)));
    m_pCommandBars = (CXTPCommandBars*) pCommandBarsClass->CreateObject();
    ASSERT(m_pCommandBars);
    if (!m_pCommandBars)
        return FALSE;
    m_pCommandBars->SetSite(this);
    m_pCommandBars->EnableDocking();
    return TRUE;
}