Codejock Developer Community : Minor coding error

Minor coding error : mgampi wrote:Hi;I thought...

Thu, 16 Apr 2009 07:03:35 +0000

Author: ABuenger
Subject: 14023
Posted: 16 April 2009 at 7:03am

mgampi wrote:

Hi;

I thought nowadays operator new throws a std::bad_alloc exception...

http://support.microsoft.com/?scid=kb%3Ben-us%3B167733&x=21&y=11

Minor coding error : Hi;I thought nowadays operator...

Wed, 15 Apr 2009 17:24:18 +0000

Author: mgampi
Subject: 14023
Posted: 15 April 2009 at 5:24pm

Hi;

I thought nowadays operator new throws a std::bad_alloc exception...

Minor coding error : znakeeye wrote:BOOL CXTPPropertySheet::AddButton(UINT...

Wed, 15 Apr 2009 06:01:44 +0000

Author: ABuenger
Subject: 14023
Posted: 15 April 2009 at 6:01am

znakeeye wrote:

BOOL CXTPPropertySheet::AddButton(UINT nIDCaption, UINT nID)
{
CString strButton;
CXTPResourceManager::AssertValid(XTPResourceManager()->LoadString(&strButton, nIDCaption));

CButton* pButton = new CButton();
if (!pButton->Create(strButton, WS_CHILD | BS_PUSHBUTTON | WS_TABSTOP | WS_VISIBLE, CRect(0, 0, 0, 0), this, nID))
return FALSE;

Shouldn't happen, but if it does there will be a leak...

Shouldn't that be
if (!pButton || !pButton->Create(...))

Minor coding error : Thanks.

Wed, 15 Apr 2009 04:25:26 +0000

Author: Oleg
Subject: 14023
Posted: 15 April 2009 at 4:25am

Thanks.

Minor coding error : BOOL CXTPPropertySheet::AddButton(UINT...

Wed, 15 Apr 2009 03:39:25 +0000

Author: znakeeye
Subject: 14023
Posted: 15 April 2009 at 3:39am

BOOL CXTPPropertySheet::AddButton(UINT nIDCaption, UINT nID)
{
CString strButton;
CXTPResourceManager::AssertValid(XTPResourceManager()->LoadString(&strButton, nIDCaption));

CButton* pButton = new CButton();
if (!pButton->Create(strButton, WS_CHILD | BS_PUSHBUTTON | WS_TABSTOP | WS_VISIBLE, CRect(0, 0, 0, 0), this, nID))
return FALSE;

Shouldn't happen, but if it does there will be a leak...