Codejock Developer Community : Closing skinned app crashes in AfxGetAmbientActCtx

Closing skinned app crashes in AfxGetAmbientActCtx : Hi,We still have the problem when...

Thu, 30 Mar 2017 05:03:50 +0000

Author: Insad
Subject: 13554
Posted: 30 March 2017 at 5:03am

Hi,

We still have the problem when we enable the possibility for the user to select his own theme/style.

Our work around is that we have selected a fixes theme/style and have disabled the functionality that the user can switch his theme/style.

Not as good as we hoped for, but in small, simple sample applications we can't get it to reproduce.

Possibly it has something to do with the fact that we use multi threading and somewhere a handle is used from the wrong thread or something?
We did have that problem with MAPI as well but here we managed to solve this ;)

We test to see the problem is resolved in each release from TKP but so far no luck.

But we have high hopes for v18.0, if it ever gets released..

Closing skinned app crashes in AfxGetAmbientActCtx : Hi;Just tested 17.3.0 and I can...

Wed, 29 Mar 2017 12:11:12 +0000

Author: mgampi
Subject: 13554
Posted: 29 March 2017 at 12:11pm

Hi;

Just tested 17.3.0 and I can still get the error!

It's all time reproducable!

Take a skinned application
Within the app call a exported C function into a regular DLL that opens a CXTPResizeDialog derived non modal dialog box.
The XTPResizeDialog derived class contains a CXTPToolbar:

... InitCommandBars();

  CXTPCommandBars* CommandBars = GetCommandBars();
  Toolbar_.SetCommandBars(CommandBars);
  VERIFY(Toolbar_.CreateToolBar(WS_TABSTOP|WS_VISIBLE|WS_CHILD|CBRS_TOOLTIPS, this));
  VERIFY(Toolbar_.LoadToolBar(IDR_TOOLBAR));
  Toolbar_.ShowExpandButton(FALSE);
  Toolbar_.SetFlags(xtpFlagAlignTop|xtpFlagStretched);

  CommandBars->EnableCustomization(FALSE);
    CommandBars->GetCommandBarsOptions()->ShowKeyboardCues(xtpKeyboardCuesShowWindowsDefault);
  CommandBars->GetToolTipContext()->SetStyle(xtpToolTipResource); ...

Whenever the app is closed after the dialog is shown I get the crash with this call stack:

>    mfc90ud.dll!AfxGetAmbientActCtx()  Zeile 37 + 0xa Bytes    C++
     mfc90ud.dll!AFX_MAINTAIN_STATE2::AFX_MAINTAIN_STATE2(AFX_MODULE_STATE * pNewState=0x10c7a028)  Zeile 86 + 0x5 Bytes    C++
     mfc90ud.dll!CCmdTarget::InternalRelease()  Zeile 173 + 0x14 Bytes    C++
     ToolkitPro1730vc90UD.dll!CXTPResourceImages::RemoveAll()  Zeile 688 + 0xe Bytes    C++
     ToolkitPro1730vc90UD.dll!CXTPResourceTheme::~CXTPResourceTheme()  Zeile 154    C++
     ToolkitPro1730vc90UD.dll!CXTPRibbonTheme::~CXTPRibbonTheme()  Zeile 155 + 0x8 Bytes    C++
     ToolkitPro1730vc90UD.dll!CXTPRibbonTheme::`vector deleting destructor'()  + 0x57 Bytes    C++
     mfc90ud.dll!CCmdTarget::OnFinalRelease()  Zeile 579 + 0x21 Bytes    C++
     mfc90ud.dll!CCmdTarget::InternalRelease()  Zeile 175    C++
     ToolkitPro1730vc90UD.dll!CXTPCommandBars::~CXTPCommandBars()  Zeile 266 + 0x14 Bytes    C++
     ToolkitPro1730vc90UD.dll!CXTPCommandBars::`vector deleting destructor'()  + 0x57 Bytes    C++
     mfc90ud.dll!CCmdTarget::OnFinalRelease()  Zeile 579 + 0x21 Bytes    C++
     mfc90ud.dll!CCmdTarget::InternalRelease()  Zeile 175    C++
     ToolkitPro1730vc90UD.dll!CXTPCommandBarsSiteBase::~CXTPCommandBarsSiteBase()  Zeile 54 + 0x1a Bytes    C++
     ToolkitPro1730vc90UD.dll!CXTPFrameWndBase::~CXTPFrameWndBase()  Zeile 235 + 0x8 Bytes    C++
     ToolkitPro1730vc90UD.dll!CXTPFrameWnd::~CXTPFrameWnd()  + 0x16 Bytes    C++
     XREngine.exe!CMainFrame::~CMainFrame()  Zeile 218 + 0x122 Bytes    C++
     XREngine.exe!CMainFrame::`scalar deleting destructor'()  + 0x2b Bytes    C++
     mfc90ud.dll!CView::PostNcDestroy()  Zeile 121 + 0x21 Bytes    C++
     mfc90ud.dll!CWnd::OnNcDestroy()  Zeile 864    C++
     mfc90ud.dll!CWnd::OnWndMsg(unsigned int message=130, unsigned int wParam=0, long lParam=0, long * pResult=0x0018edb8)  Zeile 2042    C++
     ToolkitPro1730vc90UD.dll!CXTPCommandBarsSiteBase::OnWndMsg(unsigned int message=130, unsigned int wParam=0, long lParam=0, long * pResult=0x0018edb8)  Zeile 199 + 0x18 Bytes    C++
     mfc90ud.dll!CWnd::WindowProc(unsigned int message=130, unsigned int wParam=0, long lParam=0)  Zeile 1755 + 0x20 Bytes    C++
     mfc90ud.dll!AfxCallWndProc(CWnd * pWnd=0x05feb1f8, HWND__ * hWnd=0x00131748, unsigned int nMsg=130, unsigned int wParam=0, long lParam=0)  Zeile 240 + 0x1c Bytes    C++
     mfc90ud.dll!AfxWndProc(HWND__ * hWnd=0x00131748, unsigned int nMsg=130, unsigned int wParam=0, long lParam=0)  Zeile 403    C++
     mfc90ud.dll!AfxWndProcBase(HWND__ * hWnd=0x00131748, unsigned int nMsg=130, unsigned int wParam=0, long lParam=0)  Zeile 441 + 0x15 Bytes    C++
     user32.dll!75958e71()     
     [Unten angegebene Rahmen sind möglicherweise nicht korrekt und/oder fehlen, keine Symbole geladen für user32.dll]    
     user32.dll!759590d1()     
     user32.dll!75958fce()     
     user32.dll!75964d95()     
     ToolkitPro1730vc90UD.dll!CXTPSkinManagerApiHook::OnHookCallWindowProcW(long (HWND__ *, unsigned int, unsigned int, long)* lpPrevWndFunc=0x785f1ab0, HWND__ * hWnd=0x00131748, unsigned int Msg=130, unsigned int wParam=0, long lParam=0)  Zeile 1399 + 0x1e Bytes    C++
     ToolkitPro1730vc90UD.dll!CXTPHookManager::HookWndProc(HWND__ * hWnd=0x00131748, unsigned int message=130, unsigned int wParam=0, long lParam=0)  Zeile 431 + 0x1c Bytes    C++
     user32.dll!75958e71()     
     user32.dll!7595ae9d()     
     user32.dll!75958fce()     
     user32.dll!7595932c()     
     user32.dll!7595d821()     
     ntdll.dll!776d0596()     
     mfc90ud.dll!CWnd::DestroyWindow()  Zeile 1007 + 0xd Bytes    C++
     DWrite.dll!6c006100()

When I do not create the toolbar (remove the lines of code above) the app closes without any crash.

Any ideas or a workaround? Now it is really urgent, because release date is near and I have no other possibility to make huge design changes!

Closing skinned app crashes in AfxGetAmbientActCtx : The initial issue should be fixed...

Sun, 19 Mar 2017 22:34:20 +0000

Author: astoyan
Subject: 13554
Posted: 19 March 2017 at 10:34pm

The initial issue should be fixed in 17.3 though you still need to make sure you call LoadSkin(NULL, NULL) prior to application exit. In 18.0 you won't need to do it.

The issue with WM_QUIT hasn't been reported for a while, I assume it's been fixed after 15.3.1 but cannot be sure.

If you still can reproduce anything of that in the latest version please provide details or a sample, we'll try to fix it in 18.0.

Regards,

Alexander

Closing skinned app crashes in AfxGetAmbientActCtx : Still an issue!!Eventually fixed...

Fri, 17 Mar 2017 07:44:45 +0000

Author: mgampi
Subject: 13554
Posted: 17 March 2017 at 7:44am

Still an issue!!
Eventually fixed in 17.3?

Closing skinned app crashes in AfxGetAmbientActCtx : Hello;Has anyone every solved...

Tue, 09 Feb 2016 01:03:19 +0000

Author: mgampi
Subject: 13554
Posted: 09 February 2016 at 1:03am

Hello;

Has anyone every solved this problem?
I'm using toolkit 15.3.1 and now I'm facing the same problem.
In my case, static linking is no valid option.

TIA

Martin

Closing skinned app crashes in AfxGetAmbientActCtx : I have seen several activation...

Mon, 01 Feb 2010 11:08:52 +0000

Author: Smucker
Subject: 13554
Posted: 01 February 2010 at 11:08am

I have seen several activation context problems and crashes caused by DLLs injected into the process (Logitech's SetPoint for example). I believe they no longer occur in my application because I statically link to Codejock and MFC.

See this thread for another example.

Another possible workardound: if you're not running on Windows 9x/ME (where GDI and USER stuff leak systemwide), and have closed or flushed all your streams and database connections, using TerminateProcess() will result in a clean and quick application shutdown.

Closing skinned app crashes in AfxGetAmbientActCtx : Hi, Sorry for bumping this...

Mon, 01 Feb 2010 05:13:25 +0000

Author: Insad
Subject: 13554
Posted: 01 February 2010 at 5:13am

Hi,

Sorry for bumping this post but it is still a major issue for us.

Currently we deliver our products with skinning disabled, but one of our key points where suppose to be the skinning possibilities.

The issue still happens in TKP 13.2.1.

The mentioned testcase is also still showing the issue.

Can/do I need to provide you with more information?

Thanks in advance.

Closing skinned app crashes in AfxGetAmbientActCtx : Nope, no WM_QUIT message. A...

Wed, 12 Aug 2009 04:31:50 +0000

Author: Insad
Subject: 13554
Posted: 12 August 2009 at 4:31am

Nope, no WM_QUIT message.

A simple testcase which fails:

Create a simple dialog based app, with skinning.

In the InitInstance skinning is enabled, a skin is loaded, a dialog is created, the DoModal() is done and the InitInstance returns FALSE.

In the ExitInstance i call the LoadSkin(NULL,NULL); --> This crashes!

Note that i check to see if skinning is Enabled before calling the LoadSkin(NULL,NULL);

The EXE-dialog has a button, and when pressed in loads a DLL (LoadLibraryEx/GetProcAddress/etc.) and calls a function in the DLL which creates a new dialog which just let you press OK or Cancel.

Then the Dialog in the DLL is destructed and the DLL terminates and is unloaded by the calling EXE.

When back in the EXE-dialog, you can press Cancel to exit the application.

I've tried several different skin-files; all fail. When providing NO skinfile, the InitInstance calls LoadSkin(NULL,NULL), and the application does not crash (hence: I am not calling the LoadSkin(NULL,NULL) when skinning is not enabled ; Using the function IsEnabled() in the skinmanager)

Closing skinned app crashes in AfxGetAmbientActCtx : Wild guessing again... but please...

Sat, 08 Aug 2009 08:21:21 +0000

Author: znakeeye
Subject: 13554
Posted: 08 August 2009 at 8:21am

Wild guessing again... but please see this thread: http://forum.codejock.com/forum_posts.asp?TID=14933

What if your application receives WM_QUIT somehow and crash in a similar way as mine? Use Spy++ and look for it! (Not when debugging as this might hang your computer thoroughly!)

Closing skinned app crashes in AfxGetAmbientActCtx : Hi, I assume you mean in the...

Fri, 07 Aug 2009 05:34:51 +0000

Author: Insad
Subject: 13554
Posted: 07 August 2009 at 5:34am

Hi,

I assume you mean in the ExitInstance of the EXE.

The LoadSkin(NULL,NULL); is already in place and is the function that causes the crash.

Added the RemoveAll() will not add any value since the application is already crashed before reaching it

I was wondering:

Is there possibly something that needs to be done in the unload of the DLL or in the destroy of the dialog created in the DLL?

The crash does not occour when I don't call the dialog in the DLL: I do all initialisation in my DLL code but never create the Dialog and, as you would understand, don't call it :)