Report control ExpandAll is not working

Can't confirm - Looks like it works properly.

You right. There is no traverse across all tree - only care abour 2 levels - parent and childs.

this version of ExpandAll covered your case properly - now we need to extend it to common case (using recursive function or while(...)  loop...)

You can try to test https://forum.codejock.com/uploads/DemoVersion/ReportSampleSatic.rar where Properties form have right button click handler to add childs to row where you click. There are two button on top "A" and "a".

I tried the new ExpandAll method you gave here as a replacement, but I have a buggy behaviour with it. I did my own ExpandRows which works like this :


void ExpandRows ( CXTPReportRows* pRows )
{
     // for each row
     unsigned int uiRowCount = pRows -> GetCount();
     for ( unsigned int ui = 0; ui < uiRowCount; ui++ )
     {
          // get
          CXTPReportRow* pRow = pRows -> GetAt ( ui );

          // expand
          if ( ! pRow -> IsExpanded() )
          {
               pRow -> SetExpanded( TRUE );
          }

          // process recursively
          ExpandRows ( pRow -> GetChilds() );
     }
}


But this give me half my tree expanded. If I execute this method twice, I have more nodes expanded. The more I execute the method, the more expanding I get. I suspect the CXTPReportControl::_DoExpand method to be buggy, something to be linked with an item count or something like that. It is like the more rows we have in the report, the more expand actions are done, like if having 10 visible rows in report will allow less expand done than having 20 rows visible in report.

Did you get it ?

I hope you will quicly find the problem and offer a solution, it is blocking for me and I sadly need to resolve this issue.

EDIT : using your function I even have an assertion ASSERT(pRow->m_bVisible) in the method CXTPReportControl::RefreshIndexes. The rows are displayed in a buggy order, child rows being displayed at wrong index. Please fix it as quickly as possible as it is really really blocking for our software release.

EDIT : here is a way to reproduce it, simply create a tree like this (letters are order of creation of records, I don't know if it counts):
A
C
    D
      E
B
Populate, display control and try to expand with the mouse all the nodes, you might have this :
      E
A
C
    D
      E
B
Clicking on expand plus will make it asserts.

I'm using version 12.0.0

Thank you.

Alexis.

mdoubson wrote: You can try to test https://forum.codejock.com/uploads/DemoVersion/ReportSampleSatic.rar where Properties form have right button click handler to add childs to row where you click. There are two button on top "A" and "a". "A" doing recursive ExpandAll, "a" - non-recursive. Adding new childs to this resizable form you can construct very complicated tree structure and after test ExpandAll in my code and also using your one - are you supported any number of tree structure levels?

Ok, the sample seems to work ok - is it using the code snippet above or something else?

mdoubson wrote: Of course not - this snippet is some client code (may be even for special case!?) - but in the sample you are running my code - a part of current source

Ok, so I assume it'll work in the next update then, right? I can live with what I have written myself for the time being, till CJ is updated and I can use internal functionality better.

mdoubson wrote: Don't use your own function if there is core function which now doing the job. If you want to expand all items in full tree - you should start from the top.

I tried to use my own function because the function ExpandAll is the version 12.0.0 have bugs. I 'm obvisouly not pleased to reinvent the wheel and loose my time trying to fix 3rd party code.

mdoubson wrote: If you need fresh source - open issue and if if have valid license for 2009 - I will attach you fresh source or ActiveX - depends of your purchase. I am not going to fix smth in old version - this is obvious not logical - we are moving only forward - not back!

I guess my office have no other choice than buying the latest upgrade.

My office bought the latest version (13.0.0) and I still have the same bug with the ExpandAll function code you provided above in this thread.

The ExpandAll provided with the 13.0.0 obviously do not work properly, code provided here has a bug, but my ExpandRows function that I provided above now do the job, use it by doing ExpandRows ( pReportControl->GetRows() ) and voila. So I will use my own function rather than your core function that do not do the job.

I also discovered another bug while playing with the ReportAddRecordEx sample. I'm doing a new discussion thread for this one.

I know that 13.0 did not fix this problem - only 13.1 - this is why I asked forum to test static app based on new code