[solved] v18.0 CXTPSystemVersion::GetComCtlVersion
Printed From: Codejock Forums
Category: Codejock Products
Forum Name: Toolkit Pro
Forum Description: Topics Related to Codejock Toolkit Pro
URL: http://forum.codejock.com/forum_posts.asp?TID=23410
Printed Date: 23 April 2024 at 8:15pm
Software Version: Web Wiz Forums 12.04 - http://www.webwizforums.com
Topic: [solved] v18.0 CXTPSystemVersion::GetComCtlVersion
Posted By: MGebler
Subject: [solved] v18.0 CXTPSystemVersion::GetComCtlVersion
Date Posted: 09 August 2017 at 6:31am
|
I found an implementation error in your latest release: DWORD CXTPSystemVersion::GetComCtlVersion() const { static DWORD dwVersion = 0; if (0 != dwVersion) { dwVersion = CXTPModuleHandle(_T("comctl32.dll")).GetVersion(); if (0 == dwVersion) dwVersion = MAKELONG(0, 4); // Old ComCtl32 had version 4.0 } return dwVersion; } the correct implementation would be: DWORD CXTPSystemVersion::GetComCtlVersion() const { static DWORD dwVersion = 0; if (0 == dwVersion) { dwVersion = CXTPModuleHandle(_T("comctl32.dll")).GetVersion(); if (0 == dwVersion) dwVersion = MAKELONG(0, 4); // Old ComCtl32 had version 4.0 } return dwVersion; } One effect is that some image lists do not support the alpha channel of icons. Regards Marcus |
Replies:
Posted By: olebed
Date Posted: 09 August 2017 at 8:01am
|
Hello Marcus, We have fixed this yesterday. Other customer on support reported about this bug. I have investigated what it can affect on: - BalloonStyle tooltips not supported. CXTPToolTipContext::IsBalloonStyleSupported() - alpha icons handling CXTPImageManagerResource::Add() -> CXTPImageManager::IsAlphaIconsImageListSupported() - inflate ReBar for 4 px in CXTPReBarBase::_AddBar() - CXTPWinThemeWrapper::IsAppThemeReady() can return FALSE instead of TRUE (used in very many places); - CXTPTaskDialogProgressCtrl drawing - using user defined colors in CXTPTreeBase::GetTreeBackColor() and CXTPTreeBase::GetTreeTextColor() - wrong return value in CXTPAuxData::GetComCtlVersion() - wrong return value in CXTPSkinManager::IsComCtlV6() -> CXTPSkinObjectToolBar::IsAlphaImageList()
Thank you. Oleksandr Lebed |
Posted By: g_j_a_i_n
Date Posted: 12 September 2017 at 7:58am
|
This is a silly and serious bug. You need to release a new update as soon as possible. When is next update expected?
|
Posted By: Jebo
Date Posted: 17 October 2017 at 9:08am
|
In Version 18 it is not possible anymore to use Alpha-Icons from picture-sources... For example (comparison: Version 15 and Version 18):   As you can see the Alpha-Icons are distorted!!!  Example Source-Code: uploads/1570/SourceCode_BUG-Example.zip" rel="nofollow - SourceCode_BUG-Example.zip ------------- [Sig removed by Admin: Signature can't exceed 40GB] |
Posted By: olebed
Date Posted: 17 October 2017 at 2:09pm
|
Hi, We have started to compile all significant fixes in new branch. I hope we will release it soon. Regards, Oleksandr Lebed |
Posted By: rdhd
Date Posted: 28 November 2017 at 2:37pm
|
We pulled 18.0.1 and just tracked down the same bug in the code and that led me here via a search. Is this fixed or not? If so, what version? |
Posted By: olebed
Date Posted: 28 November 2017 at 2:43pm
|
Helle rdhd, This bug fixed in v18.2 Regards, Oleksandr Lebed |