Report Control - [solved] BUG: Drag&Drop in v17.3.0 not working

Print Page | Close Window

[solved] BUG: Drag&Drop in v17.3.0 not working

Printed From: Codejock Forums
Category: Codejock Products
Forum Name: Report Control
Forum Description: Topics Related to Codejock Report Control
URL: http://forum.codejock.com/forum_posts.asp?TID=23346
Printed Date: 26 April 2024 at 11:18pm
Software Version: Web Wiz Forums 12.04 - http://www.webwizforums.com

Topic: [solved] BUG: Drag&Drop in v17.3.0 not working

Posted By: mgampi
Subject: [solved] BUG: Drag&Drop in v17.3.0 not working
Date Posted: 29 May 2017 at 9:37am

Hi;
I'm using Toolkit 17.3.0 and in ReportSample application / Quality assurance / Drag & Drop drag and drop is definitely not working. Nothing happens there?
What's the problem?

-------------
Martin

Product: Xtreme Toolkit v 19.0.0, new Projects v 19.1.0
Platform: Windows 10 v 1909 (64bit)
Language: VC++ 2017

Replies:

Posted By: mgampi
Date Posted: 29 May 2017 at 10:42am

Hi;

It took me several hours to find out that Drag&Drop in v17.3.0 is no longer working. The ReportSample > Quality Assurance > Drag&Drop example shows the same faulty behaviour.
Problem is in code of CXTPReportControl::OnDrop, line 4989:

    if (m_bInternalDrag && dropEffect == DROPEFFECT_MOVE)
    {
        m_bInternalMove = TRUE;

        if (nDropPos == -1)
            return FALSE;

        BOOL bRedraw = FALSE;
        if (!m_bNoNeedSortedDragDrop && m_bSortedDragDrop && GetColumns()->GetGroupsOrder()->GetCount() == 0)
        {
            ReleaseSorted();
            bRedraw = TRUE;
        }

        pDropRecords = new CXTPReportRecords(TRUE);
        if (/*!iValid && */(!_GetSelectedRows(pDropRecords) || pDropRecords->GetCount() == GetRows()->GetCount()))
        {
            CMDTARGET_RELEASE(pDropRecords);
            return FALSE;
        }

        if (bRedraw)
        {
            Populate();
            RedrawControl();
        }

At the red marked position iValid is always 1 (it's the result of the XTP_NM_REPORT_HASVALIDDROPTYPE message). If it would be 0 the function returns immediately at line 4934. Therefore the dropped records collection is never filled!

Please fix this before releasing 18.0!

-------------
Martin

Product: Xtreme Toolkit v 19.0.0, new Projects v 19.1.0
Platform: Windows 10 v 1909 (64bit)
Language: VC++ 2017

Posted By: olebed
Date Posted: 29 May 2017 at 11:27am

Hello Martin,

I have checked that sample and it works under win8.1(x64), VS2015, x86 and x64 ToolkitProlib.
Please describe your environment. Steps to reproducing and other things which can help.

Regards,
Oleksandr Lebed

Posted By: mgampi
Date Posted: 29 May 2017 at 11:41am

Hi;

take a look at this:

http://forum.codejock.com/forum_posts.asp?TID=23346&PID=75810&title=bug-dragdrop-in-v1730-not-working#75810" rel="nofollow - http://forum.codejock.com/forum_posts.asp?TID=23346&PID=75810&title=bug-dragdrop-in-v1730-not-working#75810

I use windows 8.1, VS2008, 32bit application compiled with UNICODE defined
Both controls on the sample do nothing! Neither start drag nor drop!

-------------
Martin

Product: Xtreme Toolkit v 19.0.0, new Projects v 19.1.0
Platform: Windows 10 v 1909 (64bit)
Language: VC++ 2017

Posted By: mgampi
Date Posted: 29 May 2017 at 12:05pm

Hi;

Here are parts of my code:

INITIALIZATION

    FacilityCtrl_.SetTheme(xtpReportThemeResource);

  FacilityCtrl_.GetToolTipContext()->SetStyle(xtpToolTipResource);

  FacilityCtrl_.ShowHeader(FALSE);
  FacilityCtrl_.SetGridStyle(FALSE, xtpReportGridNoLines);
  FacilityCtrl_.SetGridStyle(TRUE, xtpReportGridNoLines);

  FacilityCtrl_.InitialSelectionEnable(FALSE);
  CXTPReportColumn* pCol=FacilityCtrl_.AddColumn(new CXTPReportColumn(GetColumns()->GetCount(), _T(""), 200, TRUE));
FacilityCtrl_.GetColumns()->GetSortOrder()->Clear();

  FacilityCtrl_.GetRecords()->SetCaseSensitive(FALSE);
  FacilityCtrl_.GetPaintManager()->m_bShadeSortColumn=FALSE;

  FacilityCtrl_.AssignIconViewPropNumAndIconNum(-1, -1, TRUE, 20);
  FacilityCtrl_.GetPaintManager()->m_iRecOrRowStart=1;
  FacilityCtrl_.GetPaintManager()->m_bRecOrRowNum=FALSE;

  FacilityCtrl_.AllowEdit(FALSE);

  DropFormat_=FacilityCtrl_.EnableDragDrop(L"ReOrderFacilitiesFormat", xtpReportAllowDrop|xtpReportAllowDragMove|xtpReportDontDropAsText);

And my callbacks:

void CMyDlg::OnValidDropTargetRequest( NMHDR* /*Hdr*/, LRESULT* Result ) {
  *Result=1;
}

void CMyDlg::OnValidDropTypeRequest( NMHDR* Hdr, LRESULT* Result ) {
  XTP_NM_REPORTDRAGDROP* Data=reinterpret_cast<XTP_NM_REPORTDRAGDROP*>(Hdr);
  if (Data->pDataObject)
    *Result=Data->pDataObject->IsDataAvailable(DropFormat_);
  else
    *Result=0;
}

Nothing else - except filling several records (about 50) to the control and populate.
When removing the red part as shown in my initial post, everything works as expected.
BTW: I use d&d only in the same control to reorder rows.

-------------
Martin

Product: Xtreme Toolkit v 19.0.0, new Projects v 19.1.0
Platform: Windows 10 v 1909 (64bit)
Language: VC++ 2017

Posted By: olebed
Date Posted: 01 June 2017 at 7:30am

mgampi wrote:

        if (/*!iValid && */(!_GetSelectedRows(pDropRecords) || pDropRecords->GetCount() == GetRows()->GetCount()))
        {
            CMDTARGET_RELEASE(pDropRecords);
            return FALSE;
        }

At the red marked position iValid is always 1

So when iValid is 1 then this condition doesn't work and DROP operation continue to execute. This code works from 2009 year and I can't found such problems with XTP_NM_REPORT_HASVALIDDROPTYPE.

Posted By: mgampi
Date Posted: 01 June 2017 at 7:38am

Hello;

The Problem is, that _GetSelectedRows(pDropRecords) is not called because !iValid is ALWAYS FALSE and the second part of the if condition is not further examined!
Therefore the succeeding code has no valid records in the pDropRecords collection.

We can reproduce the error on all of our machines with VS2008 up to VS2015 32bit and 64bit.

-------------
Martin

Product: Xtreme Toolkit v 19.0.0, new Projects v 19.1.0
Platform: Windows 10 v 1909 (64bit)
Language: VC++ 2017

Posted By: olebed
Date Posted: 01 June 2017 at 8:42am

This bug can be reproduced on our Drag'n'Drop sample only with changes of code - with introducing XTP_NM_REPORT_HASVALIDDROPTYPE callbacks. That is why I couldn't reproduce.

So fix is

if (!iValid && (!_GetSelectedRows(pDropRecords) || pDropRecords->GetCount() == GetRows()->GetCount()))

if (!_GetSelectedRows(pDropRecords) || pDropRecords->GetCount() == GetRows()->GetCount())

Posted By: mgampi
Date Posted: 01 June 2017 at 8:46am

When you take a real close look at the code, than you see that the iValid is always one at this line of code. It can't be 0 because the method is exited in this case a few lines above. And it is not changed beween set by XTP_NM_REPORT_HASVALIDDROPTYPE and the if statement.
So I mean that it can be removed without any problems.

-------------
Martin

Product: Xtreme Toolkit v 19.0.0, new Projects v 19.1.0
Platform: Windows 10 v 1909 (64bit)
Language: VC++ 2017

Posted By: olebed
Date Posted: 01 June 2017 at 8:47am

I have changed my previous post before your answer Smile

Posted By: mgampi
Date Posted: 01 June 2017 at 9:16am

Hi;

I'm still convinced that the iValid part can be completely removed!

-------------
Martin

Product: Xtreme Toolkit v 19.0.0, new Projects v 19.1.0
Platform: Windows 10 v 1909 (64bit)
Language: VC++ 2017

Posted By: olebed
Date Posted: 01 June 2017 at 9:19am

yes, I have already removed it.
Thank you for bringing this to our attention!