Virtual OnValueChanged arguments changed
Printed From: Codejock Forums
Category: Codejock Products
Forum Name: Property Grid
Forum Description: Topics Related to Codejock Property Grid
URL: http://forum.codejock.com/forum_posts.asp?TID=19884
Printed Date: 27 April 2024 at 2:03pm
Software Version: Web Wiz Forums 12.04 - http://www.webwizforums.com
Topic: Virtual OnValueChanged arguments changed
Posted By: cpede
Subject: Virtual OnValueChanged arguments changed
Date Posted: 20 June 2012 at 10:06am
|
Aggg, you just changed the virtual method from:
virtual void OnValueChanged(CString strValue); in v15.2.1, to
virtual void OnValueChanged(const CString &strValue);
in v15.3.1, WITHOUT WRITING IT IN THE RELEASE NOTES.
This of cause breaks all existing code without any compiler warnings etc.
-cpede ------------- Product: Xtreme ToolkitPro (20.3.0) Platform: Windows 10 (x64) Language: Visual Studio 2017 (C++) |
Replies:
Posted By: SuperMario
Date Posted: 21 June 2012 at 3:01pm
|
Thanks, the changes have been reverted for the next release so you can still use your existing code. void CXTPPropertyGridItem::OnValueChanged(CString strValue) |
Posted By: adrien
Date Posted: 01 August 2012 at 8:04pm
|
I Just got bitten by this, we will have to re-release all our products. These things are not obvious in testing. You don't expect a property grid item to stop working, it still looks ok. If you change it back, that's just going to mean we have to re-change all our code back again - we already fixed it up. So please just leave it. ------------- http://www.wingate.com - http://www.wingate.com |
Posted By: cpede
Date Posted: 20 August 2012 at 10:08am
|
Agree... ------------- Product: Xtreme ToolkitPro (20.3.0) Platform: Windows 10 (x64) Language: Visual Studio 2017 (C++) |
Posted By: apautrot
Date Posted: 24 August 2012 at 4:53am
|
Yeah I was about to post about that. "Thanks, the changes have been reverted for the next release so you can still use your existing code." And so we will have to re-change all the calls again... you should stick to the change once for all.
------------- Win 7 x64 VS 2008 CJ 15.13 |
Posted By: MarkWoodard
Date Posted: 30 September 2012 at 12:23pm
| CodeJock even broke some of their own code with this change: CXTPPropertyGridItemSize and CSTPPropertyGridItemPoint no longer work correctly, and who knows how many other property items of theirs? |
Posted By: MarkWoodard
Date Posted: 30 September 2012 at 12:39pm
|
OK, I haven't tested all of these, but I'm sure they are all unhealthy, because they all use the incorrect override of OnValueChanged.
CXTPPropertyGridItemFlags
CXTPPropertyGridItemDate
CXTPPropertyGridItemSize
CXTPPropertyGridItemPoint
This obvious fix is to fix the method signatures and recompile the libraries.
 |
Posted By: Fredrik
Date Posted: 08 October 2012 at 6:59am
|
> Thanks, the changes have been reverted for the next release so you can still use your existing code. > virtual void OnValueChanged(CString strValue);> void CXTPPropertyGridItem::OnValueChanged(CString strValue) When is the next release? Is the decision still that this change will be reverted in the next release?
------------- Windows 10, Visual Studio 20157, Toolkit Pro 18.3.0 |