Codejock Forums Homepage
Forum Home Forum Home > Codejock Products > Visual C++ MFC > Toolkit Pro
  New Posts New Posts RSS Feed - [BUG?] XTPControlGallery.cpp(362)
  FAQ FAQ  Forum Search   Events   Register Register  Login Login

[BUG?] XTPControlGallery.cpp(362)

 Post Reply Post Reply
Author
Message
znakeeye View Drop Down
Senior Member
Senior Member
Avatar

Joined: 26 July 2006
Status: Offline
Points: 1672
Post Options Post Options   Thanks (0) Thanks(0)   Quote znakeeye Quote  Post ReplyReply Direct Link To This Post Topic: [BUG?] XTPControlGallery.cpp(362)
    Posted: 17 August 2011 at 4:48am
XTP 15.1.2
CString strCaption;
if (nId > 0 && strCaption.LoadString(nId))
{
    pItem->SetCaption(strCaption);
 
 
What if pItem already has a caption? Is the above really correct? (Not to mention that you should always use your own XTPResourceManager()->LoadString().)
 
I would suggest something like this:
 
CString strCaption;
if (nId > 0 && pItem->GetCaption().GetLength() == 0 && strCaption.LoadString(nId))
{
     pItem->SetCaption(strCaption);
PokerMemento - http://www.pokermemento.com/
Back to Top
Oleg View Drop Down
Admin Group
Admin Group


Joined: 21 May 2003
Location: United States
Status: Offline
Points: 11234
Post Options Post Options   Thanks (0) Thanks(0)   Quote Oleg Quote  Post ReplyReply Direct Link To This Post Posted: 24 August 2011 at 8:26am
Hi,

Thanks, good suggestion.
Oleg, Support Team
CODEJOCK SOFTWARE SOLUTIONS
Back to Top
 Post Reply Post Reply
  Share Topic   

Forum Jump Forum Permissions View Drop Down

Forum Software by Web Wiz Forums® version 12.04
Copyright ©2001-2021 Web Wiz Ltd.

This page was generated in 0.141 seconds.