Vertical Scroll Bug?

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

   If you have a ReportControl narrow enough that only two rows are visible, and at that, the second is only partially visible (text leading off to another line or two below the window; might need a multiline text cell to accomplish this), if  the user clicks below the thumb tracker in the scroll bar no scrolling occurs.  I have debugged through this and found the issue to be in CXTPReportControl::GetReportAreaRows(...), which in this case always returns zero, so the position never updates.  The code starting at line 2576 (13.1) or line 2679 (13.2) of XTPReportControl.cpp has the following in the GetReportAreaRows method:

  if (top + rowHeight > m_rcReportArea.bottom)
   return bMoveDown ? i - nStartRow - 1 : nStartRow - i - 1;

I propose the following change, but figured I'd get input here first:

  if (top + rowHeight > m_rcReportArea.bottom)
  {
      if( i == (nStartRow+ 1) )
      {
          return i;
      }
      else
      {
          return bMoveDown ? i - nStartRow - 1 : nStartRow - i - 1;
      }
  }

This does seem to solve the case found in our use of the report control, but again, wanted to run it by here for other input.

Thanks,

K.

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
binkman71 Members Profile Send Private Message Find Members Posts Add to Buddy List Newbie Joined: 22 July 2009 Status: Offline Points: 5	Post Options Post Reply Quote binkman71 Report Post Thanks(0) Quote Reply Topic: Vertical Scroll Bug? Posted: 18 January 2010 at 3:23pm
	If you have a ReportControl narrow enough that only two rows are visible, and at that, the second is only partially visible (text leading off to another line or two below the window; might need a multiline text cell to accomplish this), if the user clicks below the thumb tracker in the scroll bar no scrolling occurs. I have debugged through this and found the issue to be in CXTPReportControl::GetReportAreaRows(...), which in this case always returns zero, so the position never updates. The code starting at line 2576 (13.1) or line 2679 (13.2) of XTPReportControl.cpp has the following in the GetReportAreaRows method: if (top + rowHeight > m_rcReportArea.bottom) return bMoveDown ? i - nStartRow - 1 : nStartRow - i - 1; I propose the following change, but figured I'd get input here first: if (top + rowHeight > m_rcReportArea.bottom) { if( i == (nStartRow+ 1) ) { return i; } else { return bMoveDown ? i - nStartRow - 1 : nStartRow - i - 1; } } This does seem to solve the case found in our use of the report control, but again, wanted to run it by here for other input. Thanks, K.

mdoubson Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 17 November 2008 Status: Offline Points: 1705	Post Options Post Reply Quote mdoubson Report Post Thanks(0) Quote Reply Posted: 19 January 2010 at 4:34pm
	I can't reproduce you case - please open Issue and we can discuss it