Codejock Forums Homepage
Forum Home Forum Home > Codejock Products > Visual C++ MFC > Toolkit Pro
  New Posts New Posts RSS Feed - [solved] Ribbon bar artifact
  FAQ FAQ  Forum Search   Events   Register Register  Login Login

[solved] Ribbon bar artifact

 Post Reply Post Reply
Author
Message
mckoy View Drop Down
Newbie
Newbie


Joined: 12 February 2018
Status: Offline
Points: 7
Post Options Post Options   Thanks (1) Thanks(1)   Quote mckoy Quote  Post ReplyReply Direct Link To This Post Topic: [solved] Ribbon bar artifact
    Posted: 12 February 2018 at 6:48am
Hi.

If minimized ribbon and click to the tab, will popup ribbon, but between tab and ribbon is grey line.

   
Word ribbon                               Codejock ribbon

How I can hide the line under tab with minimized ribbon like in MS Word?
Back to Top
markr View Drop Down
Senior Member
Senior Member


Joined: 01 August 2004
Status: Offline
Points: 393
Post Options Post Options   Thanks (0) Thanks(0)   Quote markr Quote  Post ReplyReply Direct Link To This Post Posted: 07 March 2018 at 7:37pm
Hello,

In the XTP 18.3 ribbon sample (Ribbon.RibbonSample.exe), if you choose an Office 2013/2016 theme and are running at high DPI (I've tested at 150% and 200% scaling), an artifact appears when drawing tabs:



As show in the screenshot above, there's an unwanted horizontal line below the tab caption.

Wondering if there might be a source patch available for this problem.

Many thanks,

Mark R.

Back to Top
markr View Drop Down
Senior Member
Senior Member


Joined: 01 August 2004
Status: Offline
Points: 393
Post Options Post Options   Thanks (0) Thanks(0)   Quote markr Quote  Post ReplyReply Direct Link To This Post Posted: 15 March 2018 at 3:39am
Any thoughts on what might be causing this? 

I can start digging through the XTP ribbon rendering code, but any information that might help me to narrow down my investigations would be appreciated.

Regards,

Mark R.
Back to Top
olebed View Drop Down
Admin Group
Admin Group
Avatar

Joined: 01 July 2014
Location: Ukraine
Status: Offline
Points: 836
Post Options Post Options   Thanks (0) Thanks(0)   Quote olebed Quote  Post ReplyReply Direct Link To This Post Posted: 24 June 2018 at 10:50am
Hello,

Problem was in method CXTPRibbonOffice2013Theme::DrawRibbonTab()
void CXTPRibbonOffice2013Theme::DrawRibbonTab(CDC *pDC, CXTPRibbonTab *pItem)
{
......

    XTPRibbonTabContextColor tabColor = pItem->GetContextColor();
    XTPTabPosition tabPosition = pItem->GetTabManager()->GetPosition();

    CRect r(pItem->GetRect());
    CXTPTabPaintManagerTheme::InflateRectEx(r, CRect(-1, 1, -1, -1), tabPosition);
    BOOL bSelected = pItem->IsSelected();
    if (pRibbon->IsRibbonMinimized() && bSelected)
    {
        CXTPRibbonControlTab* pControlTab = (CXTPRibbonControlTab*)pItem->GetTabManager();
        if (pControlTab)
        {
            if (!pControlTab->GetCommandBar() || !pControlTab->GetCommandBar()->IsTrackingMode())
                bSelected = FALSE;
        }
    }

    if (bSelected)
    {
        r.DeflateRect(0, 0, 1, 0);
.....
Regards,
 Oleksandr Lebed
Back to Top
markr View Drop Down
Senior Member
Senior Member


Joined: 01 August 2004
Status: Offline
Points: 393
Post Options Post Options   Thanks (0) Thanks(0)   Quote markr Quote  Post ReplyReply Direct Link To This Post Posted: 25 June 2018 at 7:00pm
Hello Oleksandr,

Thanks very much for sharing this fix.

- Mark R.
Back to Top
 Post Reply Post Reply
  Share Topic   

Forum Jump Forum Permissions View Drop Down



This page was generated in 0.109 seconds.