Codejock Forums Homepage
Forum Home Forum Home > Codejock Products > Visual C++ MFC > Command Bars
  New Posts New Posts RSS Feed - [solved] v18.3 missing Ribbon group separators
  FAQ FAQ  Forum Search   Events   Register Register  Login Login

[solved] v18.3 missing Ribbon group separators

 Post Reply Post Reply
Author
Message Reverse Sort Order
Daeva View Drop Down
Newbie
Newbie
Avatar

Joined: 04 November 2016
Location: Belarus
Status: Offline
Points: 8
Post Options Post Options   Thanks (0) Thanks(0)   Quote Daeva Quote  Post ReplyReply Direct Link To This Post Topic: [solved] v18.3 missing Ribbon group separators
    Posted: 20 April 2018 at 4:51am
When do you plan to release the patch with this fix?
Back to Top
olebed View Drop Down
Admin Group
Admin Group
Avatar

Joined: 01 July 2014
Location: Ukraine
Status: Offline
Points: 831
Post Options Post Options   Thanks (0) Thanks(0)   Quote olebed Quote  Post ReplyReply Direct Link To This Post Posted: 19 April 2018 at 3:05pm
yes
Back to Top
Daeva View Drop Down
Newbie
Newbie
Avatar

Joined: 04 November 2016
Location: Belarus
Status: Offline
Points: 8
Post Options Post Options   Thanks (0) Thanks(0)   Quote Daeva Quote  Post ReplyReply Direct Link To This Post Posted: 19 April 2018 at 10:33am
Hello.
In older versions between ribbon groups was a separators. (style office 2013) Now they're gone. Is it possible to return them back?
Back to Top
agontarenko View Drop Down
Admin Group
Admin Group


Joined: 25 March 2016
Status: Offline
Points: 84
Post Options Post Options   Thanks (0) Thanks(0)   Quote agontarenko Quote  Post ReplyReply Direct Link To This Post Posted: 07 February 2018 at 10:42am
Hello,

To fix it you should be remove method:
void CXTPRibbonOffice2013Theme::DrawGroup(CDC* pDC, CXTPRibbonGroup* pGroup)

also change method void CXTPRibbonMarkupTheme::DrawGroup(CDC *pDC, CXTPRibbonGroup *pGroup) as shown below:

void CXTPRibbonMarkupTheme::DrawGroup(CDC *pDC, CXTPRibbonGroup *pGroup)
{
    ASSERT(pDC);
    ASSERT(pGroup);
    CRect rcGroup(pGroup->GetRect());

    if (!pGroup->IsReduced())
    {
        CString strCaption = pGroup->GetCaption();
        XTPDrawHelpers()->StripMnemonics(strCaption);

        LOGFONT lf;                                            //ADDED
        m_fontGroupCaption.GetLogFont(&lf);   //ADDED

        if (pGroup->IsHighlighted())
        {
            ASSERT(NULL != m_pGroupHighlighted);
            m_pGroupHighlighted->SetFontSize(-lf.lfHeight);   //ADDED
            m_pGroupHighlighted->SetCaption(strCaption);
            m_pGroupHighlighted->SetTextColor(m_clrGroupCaption);
            m_pGroupHighlighted->RenderMarkup(pDC, rcGroup);
        }
        else
        {
            ASSERT(NULL != m_pGroupNormal);
            m_pGroupNormal->SetFontSize(-lf.lfHeight);   //ADDED
            m_pGroupNormal->SetCaption(strCaption);
            m_pGroupNormal->SetTextColor(m_clrGroupCaption);
            m_pGroupNormal->RenderMarkup(pDC, rcGroup);
        }
    }
}

Regards,
Gontarenko Artem
Back to Top
olebed View Drop Down
Admin Group
Admin Group
Avatar

Joined: 01 July 2014
Location: Ukraine
Status: Offline
Points: 831
Post Options Post Options   Thanks (0) Thanks(0)   Quote olebed Quote  Post ReplyReply Direct Link To This Post Posted: 06 February 2018 at 8:30am
Hello,

Thank you for bringing this to our attention.
As quick workaround you can delete new method CXTPRibbonOffice2013Theme::DrawGroup to will be used base method  CXTPRibbonMarkupTheme::DrawGroup().  Or add calling base method in CXTPRibbonOffice2013Theme::DrawGroup  instead all other code.

Regards,
 Oleksandr Lebed
Back to Top
SvenC View Drop Down
Groupie
Groupie


Joined: 02 February 2007
Status: Offline
Points: 79
Post Options Post Options   Thanks (1) Thanks(1)   Quote SvenC Quote  Post ReplyReply Direct Link To This Post Posted: 06 February 2018 at 7:32am
Tried that and I see missing Ribbon group separators for Office 2013 and 2016 themes.

I can repro that in you Ribbon sample project as well.

Have a look at the 2016 theme on top and 2010 theme at the bottom:


--
SvenC

Toolkit Pro 15.3.1, 16.2.4, 16.3.1, 16.4.0, 17.2.0, 17.3.0, 18.0.1, 18.2 with VC++ 2010, 2012, 2013, 2015, 2017
Back to Top
 Post Reply Post Reply
  Share Topic   

Forum Jump Forum Permissions View Drop Down



This page was generated in 0.107 seconds.