[solved] v17 Flickering buttons in status bar

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

   Hi,
After upgrading from v16.3.1 to v17, the CXTPButton sub-classed buttons on the status-bar of our application have started to flicker (going from their unpressed state to pressed state) as you move the mouse around.

Each of these buttons have command update handlers which are called during idle processing time to make sure they have the correct state.   e.g. something like...

void CMainFrame::OnUpdateUtilsParallelto(CCmdUI* pCmdUI) 
{
	pCmdUI->Enable(allow_snap);
	pCmdUI->SetCheck(current_snap_type() == SNAP_PARALLEL);
}

I think the problem is related to this new code in XTPButton.cpp (introduced since v16.3.1)...

LRESULT CXTPButton::OnSetCheck(WPARAM wParam, LPARAM /*lParam*/)
{
	BOOL bVisible = GetStyle() & WS_VISIBLE;
	if (bVisible) ModifyStyle(WS_VISIBLE, 0);
	Default();
	if (bVisible) ModifyStyle(0, WS_VISIBLE);

	if (IsPushButton())
	{
		SetChecked(!GetChecked());
	}
	...

The line in bold seems to assume that because a button is a push button that calling OnSetCheck should toggle the state, when in fact, the wParam parameter indicates the desired state which could be the same as it was previously.

Changing that line to...

SetChecked(wParam==BST_CHECKED);

Fixes the problem for our application.

Dan

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
Dan Members Profile Send Private Message Find Members Posts Add to Buddy List Groupie Joined: 11 June 2014 Status: Offline Points: 16	Post Options Post Reply Quote Dan Report Post Thanks(1) Quote Reply Topic: [solved] v17 Flickering buttons in status bar Posted: 11 February 2016 at 10:39am
	Hi, After upgrading from v16.3.1 to v17, the CXTPButton sub-classed buttons on the status-bar of our application have started to flicker (going from their unpressed state to pressed state) as you move the mouse around. Each of these buttons have command update handlers which are called during idle processing time to make sure they have the correct state. e.g. something like... void CMainFrame::OnUpdateUtilsParallelto(CCmdUI* pCmdUI) { pCmdUI->Enable(allow_snap); pCmdUI->SetCheck(current_snap_type() == SNAP_PARALLEL); } I think the problem is related to this new code in XTPButton.cpp (introduced since v16.3.1)... LRESULT CXTPButton::OnSetCheck(WPARAM wParam, LPARAM /lParam/) { BOOL bVisible = GetStyle() & WS_VISIBLE; if (bVisible) ModifyStyle(WS_VISIBLE, 0); Default(); if (bVisible) ModifyStyle(0, WS_VISIBLE); if (IsPushButton()) { SetChecked(!GetChecked()); } ... The line in bold seems to assume that because a button is a push button that calling OnSetCheck should toggle the state, when in fact, the wParam parameter indicates the desired state which could be the same as it was previously. Changing that line to... SetChecked(wParam==BST_CHECKED); Fixes the problem for our application. Dan

olebed Members Profile Send Private Message Find Members Posts Add to Buddy List Admin Group Joined: 01 July 2014 Location: Ukraine Status: Offline Points: 841	Post Options Post Reply Quote olebed Report Post Thanks(0) Quote Reply Posted: 15 February 2016 at 10:46am
	Hello Dan, Thank you for bringing this to our attention. I have added your changes to our code. Regards, Oleksandr Lebed