Missing pointer test

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

   Hello,
We are having a crash there :

CXTPReportColumn* CXTPReportColumns::Find(int nItemIndex) const
{
        for (int nColumn = 0; nColumn < GetCount(); nColumn++)
        {
                CXTPReportColumn* pColumn = GetAt(nColumn);
                if (pColumn->GetItemIndex() == nItemIndex)
                        return pColumn;
        }
        return NULL;
}

We are having a case where the method GetAt(...) returns NULL, and the variable pColumn is NULL. You access directly to a member method of that variable without checking for its validity.

Our temporary workaround is to code our own Find method.

Please fix that for the next release, as we use the Find in many other parts of the code.

Thank you.

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
Sergio Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 18 September 2006 Status: Offline Points: 216	Post Options Post Reply Quote Sergio Report Post Thanks(0) Quote Reply Topic: Missing pointer test Posted: 17 October 2012 at 10:39am
	Hello, We are having a crash there : CXTPReportColumn* CXTPReportColumns::Find(int nItemIndex) const { for (int nColumn = 0; nColumn < GetCount(); nColumn++) { CXTPReportColumn* pColumn = GetAt(nColumn); if (pColumn->GetItemIndex() == nItemIndex) return pColumn; } return NULL; } We are having a case where the method GetAt(...) returns NULL, and the variable pColumn is NULL. You access directly to a member method of that variable without checking for its validity. Our temporary workaround is to code our own Find method. Please fix that for the next release, as we use the Find in many other parts of the code. Thank you.
	Sergio

mgampi Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 14 July 2003 Status: Offline Points: 1198	Post Options Post Reply Quote mgampi Report Post Thanks(0) Quote Reply Posted: 05 November 2012 at 5:26pm
	I ran into the same crash, but in my case it's not reproduceable all the time!
	Martin Product: Xtreme Toolkit v 19.0.0, new Projects v 19.1.0 Platform: Windows 10 v 1909 (64bit) Language: VC++ 2017