Fatal CalendarTheme bug and ?

XTPCalendarTheme.cpp Version 13.1 with additional fixes/enhancements

Fatal bug around line 3390 in method Draw. If values were 0 would divide by or divide into 0. I don't know if my fix is legit, but it keeps the thing from crashing.

void CXTPCalendarTheme::CTODayViewDayGroup::Draw(CCmdTarget* pObject, CDC* pDC)

// original

            if (pViewEvent->IsMultidayEvent() || pViewEvent->GetEvent()->IsAllDayEvent())
            {
                CRect rcEvent(pViewEvent->GetEventRect());
                nVisAllDayEvents = nAllDayHeight / rcEvent.Height();
                nAllDayShift = max(iCurTopRow - iTopRow, 0);
                nAllDayShift = min(nAllDayShift, nEventsCount - nVisAllDayEvents);
                nAllDayShift = max(nAllDayShift, 0);
            }

// for a quick fix I added a check for values nAllDayHeight and rcEvent.Height()

                CRect rcEvent(pViewEvent->GetEventRect());
                if (nAllDayHeight && rcEvent.Height())
                {
                    nVisAllDayEvents = nAllDayHeight / rcEvent.Height();
                    nAllDayShift = max(iCurTopRow - iTopRow, 0);
                    nAllDayShift = min(nAllDayShift, nEventsCount - nVisAllDayEvents);
                    nAllDayShift = max(nAllDayShift, 0);
                }

Now my question:

In addition, I'm experiencing an odd problem which so far has eluded me.

I use a modeless property sheet to display Event data. However, when I do, the CalendarControl will not update it's display properly.

I can move the scroll bar and date selector controls normally and all other aspects of the program take focus properly. Toolbars, tips, menus, other dialogs all work as they should. But - the calendar display itself will not update! For instance scrolling the view up or down is not reflected until the property sheet is closed. The same goes for the view type. Go from work week to month view and nothing happens... until the property sheet is closed. To make matters worse I can open other modeless property sheets derived from the same exact base class and everything works perfectly. It only happens to the property sheet when used to display an Event.

Any thoughts on how to make the calendar control keep itself up-to-date? This really has me perplexed.

Many thanks if anyone can offer some insight into this.

Mark -

Using the code from the link you provided I was still able to duplicate the modeless dialog issue.

To see the effect:

1. run the CalendarDemo program

2. select and open an existing "recurring event" from a calendar view that has other events (so you can see the effect). It doesn't seem to matter whether it's series or occurrence. You will see that the dialog acts modelessly. A regular event will be modal so do not use one for this test.

3. In the calendar view adjust the vertical scroll bar up or down so it's in a different position. Or adjust the selected dates.  While you move the event dialog around you will see that the screen is not updated correctly, but only in the areas you have passed the dialog over!

4. Close the event dialog. The screen will now be updated properly.

I hope that this information helps.

No - I was wrong (MFC and ActiveX are similar - Modal for single events and Modeleass for recurrent ones). So my question is - should we make recurrent case also Modal?

I also refresh https://forum.codejock.com/uploads/DemoVersion/CalendarControlMFCUpdated.rar

You can try updated sample - https://forum.codejock.com/uploads/DemoVersion/CalendarDemoStatic.rar

Because you don't have real modeless dialog - you need to use Create function for modeless case (and control show it - hide it - delete it some way if you want to reuse it). That we had was just wrong case of one (small) dialog called inside main modal dialog - small dialog own DoModal enable App  Main Window after small dialog end. In modeless case you need to have smth like OnApply function which will do app and control update.

You can open an issue, attach your prototype project with modeless event editor and I can help you with it.

Sure - open the issue please.

Very good.