Multiple ranged selection not working

>>2) Click between column 4 and column 5 on the header (just one mouse click)
>>3) You will see that column 4 has resized, but it should not

No - this is my posts and if I consider that content (links) description is obsolete - I am changing it to match the current links content state - it make sense. I can't touch YOUR posts so don't worry 

I have tested the sample https://forum.codejock.com/uploads/DemoVersion/ReportPaneViewStaticTrack.rar and found the issue:
1) Run the sample
2) Click between column 4 and column 5 on the header (just one mouse click)
3) You will see that column 4 has resized, but it should not

Also look on new feature - Report Control with resizable rows - select row and you can track down row height -

Yes, confirmed. Simple mouse click, with SHIFT up and CTRL up, should check if the item is already selected and if this is the case, it should not change the selection...

What do you mean with "DD" ?
When does it loose selection ?

I have just tested the new selection with our projects, and I have just seen one small bug : the message "selection changed" is not generated for all cases.
This is due to the method m_pSelectedRows->IsChanged() that is not working for all cases in SetFocusedRow(...). Please just force the "changed state" inside SetFocusedRow(...).

----------------------------------

">>The Tree Dialog Test inside the same app is working perfectly - same in Aug 25 build - I already told you it"

--> Yes, I knew it, I meant that that Codejock DLL contents was perfectly working on the Tree Dialog Test that you haven't modified.

PLEASE STOP MODIFYING PREVIOUS POSTS!

Seems to work.

But your "https://forum.codejock.com/uploads/DemoVersion/ReportSampleStaticAug27.rar" has bad columns sizes and scrollbar behavior, and this is not due to my changes... ---> You removed it from your previous post. I added this comment on 28 August 2009, why the web site does not report it ?

The Tree Dialog Test inside the same app is working perfectly.

Please check...

HAVE YOU FIXED YOUR METHOD "SelectBloc(...)" ?
Have you read my comments of my previous post ?

Hi Mark,


Here are the 3 impacted files :

    XTPReportControl.h
    XTPReportControl.cpp
    XTPReportRows.cpp

    20090827_081811_MultipleSelecti.zip


Here is the differences report in HTML format (using Beyond Compare) :

    SergioChangesReport.zip

    20090827_082034_SergioChangesRe.zip


You will have to :

- Fix your method SelectBlock(...) (See comments "----> Bugged method !"). Look at my temporary fix FixOfSelectBlock(...), and try to put your specific check in the commented line "//if (pRow->CanBeSelected())".

- Don't use CXTPReportSelectedRows::m_nRowBlockBegin but better use CXTPReportControl::m_nSelectionStartingRow. You may rename it if you prefer. The class CXTPReportControl is now a friend class of CXTPReportSelectedRows. Look at my change in the file XTPReportRows.cpp.


Regards,

I did a temporary method to do a block of selection and now, it works much better :

    void CXTPReportControl::FixOfSelectBlock(int nRowsType, int nStartingRow, int nEndingRow)


I have done all cases for keyboard and mouse. I have one last point to do : remember correctly the starting range for keyboard and mouse. I will have to create a new member variable in CXTPReportControl like :

   int m_nSelectionStartingRow;                          // Starting row index of the last bloc of selection.

Sergio - please get fresh source update - https://forum.codejock.com/uploads/DemoVersion/ReportControlMFCUpdated.rar

2) ---> OK. Now all the selection behavior is handled in the method SetFocusedRow(...)

3) I am now able to fix the selection.

Please note that :

- When changing the focus from another group (header, body or footer) of selection, the selection of the previous group will be cleared and only the focused item in the new group will be selected (SHIFT or CTRL keys will be ignored in this case), because it is impossible to select a range starting from the header and ending to the footer!

OK. I found how.

How do I enable multiple selection mode ?

I need also to test with header and footer.

Could you please give me the source code of your Report Static sample ?

Thank you.

void CXTPReportNavigator::SetMovePosition(XTPReportRowType RowType)

{

switch (RowType)

{

case xtpRowTypeBody: m_bCurrentFocusInHeadersRows = FALSE; m_bCurrentFocusInFootersRows = FALSE; break;

case xtpRowTypeHeader: m_bCurrentFocusInHeadersRows = TRUE; m_bCurrentFocusInFootersRows = FALSE; break;

case xtpRowTypeFooter: m_bCurrentFocusInHeadersRows = FALSE; m_bCurrentFocusInFootersRows = TRUE; break;

}

}

There are two functions :

    BOOL CXTPReportControl::SetFocusedRow(CXTPReportRow* pRow, BOOL bControlKey)

and

    BOOL CXTPReportControl::SetFocusedRow(CXTPReportRow* pRow, BOOL bShiftKey, BOOL bControlKey)

The 1st method have duplicate code, why does it not call the 2nd method with bShiftKey set to FALSE ?

Please get updates: no skipped childs for selection with group rows!

Sounds good - could you start it now if you have some time and I will contunie later when will have time (in the evening I guess) please? You can attach modified rar in Forum post

Good idea - add it

Here is another bug (Tree View test dialog) :

https://forum.codejock.com/uploads/DemoVersion/ReportSampleStaticExt.rar - timestamp Aug 25, 17:15 and Aug 25, 17:47

I wrote :

>> When selecting with CTRL + SHIFT, no item should be unselected, this will avoid a bug when changing selection direction (3 blocs upward and one downward).

That means that using the CTRL + SHIFT keys should select all the items in the range of the last two mouse clicks, and should not leave any unselected items in the range.

Sergio wrote: In the example https://forum.codejock.com/uploads/DemoVersion/ReportPaneViewStatic.rar (timestamp August, 20 - 15:00), this bug has resurrected :

This bug is still present.

Tested in files :

https://forum.codejock.com/uploads/DemoVersion/ReportSampleStaticExt.rar - timestamp Aug 21, 18:05 and Aug 25, 17:10
https://forum.codejock.com/uploads/DemoVersion/ReportPaneViewStatic.rar - timestamp Aug 21, 18:05 and Aug 25, 17:10

Can't confirm - my static (same as in link) - Aug 17, 18:10

In the example https://forum.codejock.com/uploads/DemoVersion/ReportPaneViewStatic.rar (timestamp August, 20 - 15:00), this bug has resurrected :

Welcome back - get https://forum.codejock.com/uploads/DemoVersion/ReportControlMFCUpdated.rar we now support vista-type DD - sorted DD

https://forum.codejock.com/uploads/DemoVersion/ReportSampleStaticExt.rar (timestamp - July, 23 - 19:10)

Sergio - as a professional you should at least comment which version of app (with timestamp of exe) you use to testing? It can be already obsolete....

Don't change direction - as you wrote "this will avoid a bug when changing selection direction"

Please get fresh updates - it works in both cases now: m_bSkipGroupsFocus = TRUE and m_bSkipGroupsFocus = FALSE

Selection in sublevels (children selection when using groups) :


1) Two lines range




2) Multiple selection of blocs

xcentric wrote: Mark, I have tested your fresh demo. Just in case you had not seen it: 1) General -> Show Markup Sample 2) Right-Click on the header -> Columns You will see a markup code instead of a column name.

>> When selecting with CTRL + SHIFT, no item should be unselected, this will avoid a bug when changing selection direction

>> (3 blocs upward and one downward).
updated here

 

 

New tests results :

• OK : Click on expand/collapse button should not change selection or generate item click / double click events.


• TO FIX : Multiple selection of blocs doesn't work for group child records.


• TO FIX : When selecting with CTRL + SHIFT, no item should be unselected, this will avoid a bug when changing selection direction (3 blocs upward and one downward).


• OK : Horizontal scrollbar that was automatically hidden.

Hi Mark,

Today I can consecrate some time to tests.

ReportSampleStaticProto tests results :

• OK : Selection persistence for group childs seems to work perfectly.


• TO FIX : Click on expand/collapse button should not change selection or generate item click / double click events.


• TO FIX : Multiple selection of blocs doesn't work for group child records.


• TO FIX : When selecting with CTRL + SHIFT, no item should be unselected, this will avoid a bug when changing selection direction (3 blocs upward and one downward).

I will now check for horizontal scrollbar that is automatically hidden.

Regards,

Mark, I have tested your fresh demo.

Just in case you had not seen it:
1) General -> Show Markup Sample
2) Right-Click on the header -> Columns

You will see a markup code instead of a column name.

Get fresh update with good selection - https://forum.codejock.com/uploads/DemoVersion/ReportControlMFCUpdated.rar

uploads/20090702_111440_ReportDialogSam.rar

Could you please be more precise ?

That's not senseless, we will distribute our products with the latest official release of Codejock, the 13.1.0, which doesn't seem to be working.

OK, you tried to fix it and now I should check it by using your latest source code.

I can't do it now, it take time to change my environment, I will test it when I will test the multiple selection.

Please wait one or three days, thank you.

I am using the Toolkit Pro of the latest release (13.1.0) to test my code.

Your sample cannot be modified to carry more columns because it's an executable.

Here is the case : each column counts for approx. 10 pixels, multiply this number with the number of columns, and now reduce the width of the report control to be lower than this number.

It doesn't occur in your sample, because you don't have as much columns as we have (approx. 100). It's working fine with a few columns.

Please try to add 100 columns in your sample.

Hi Mark,

In the release 13.1.0, the resizing of the Report Control behaves differently. When using the full column scrolling mode and when the control reaches a certain low limit, the control is automatically switched to a non-full column scrolling mode (the horizontal scrollbar is automatically hidden).

How can we now avoid that ?

OK, I will download it now!

My manager is asking me to evaluate how much time it will take. I need your latest files to estimate the work load.

Please note that any intermediary merge take time, I would appreciate if we could avoid them.

Hi, Sergio - are you ready to continue?

OK, I have to finish some work this week, I will try to do it on next week.

I would really like to continue my fix, but my manager is asking me to continue internal jobs.

I have given you the complete selection cases. To finish completely the selection behavior, I need at least 2 days (to rollback to blocks of selection and change SetFocusedRow(...), OnLButtonDown/Up(...) and OnKeyDown(...)).

What are your deadlines for this Release ?

For the external scrollbars, if you keep the last code I sent you, and change this :

void CXTPReportView::OnHScroll(UINT nSBCode, UINT nPos, CScrollBar* pScrollBar)
{
     if (m_pScrollBarHor && pScrollBar == m_pScrollBarHor)
     {
          if (nSBCode == SB_THUMBTRACK || nSBCode == SB_THUMBPOSITION)
          {
               nPos = pScrollBar->GetScrollPos();
               GetReportCtrl().SetScrollPos(SB_HORZ, nPos, FALSE);
          }

          GetReportCtrl().OnHScroll(nSBCode, nPos, NULL);
     }

     CView::OnHScroll(nSBCode, nPos, pScrollBar);
}

void CXTPReportView::OnVScroll(UINT nSBCode, UINT nPos, CScrollBar* pScrollBar)
{
     if (m_pScrollBar && pScrollBar == m_pScrollBar)
     {
          if (nSBCode == SB_THUMBTRACK || nSBCode == SB_THUMBPOSITION)
          {
               nPos = pScrollBar->GetScrollPos();
               GetReportCtrl().SetScrollPos(SB_VERT, nPos, FALSE);
          }

          GetReportCtrl().OnVScroll(nSBCode, nPos, NULL);
     }

     CView::OnVScroll(nSBCode, nPos, pScrollBar);
}

It should work.

For the VirtualMode, you're right, we should keep using blocks. But at the time I wrote my code, selection blocks had in some cases redundancies. I saw that you made some changes between the time, did you fix that? Although CXTPReportSelectedRows could manage both selections (per elements and per blocks), we perhaps better stay using one method, the block one.

Here's what I'm trying to do for the selection :

CXTPReportSelectedRows

     // To simplify CXTPReportRows* retrieval
     // Not implemented yet!
     CXTPReportRows* GetRowTypeRows()


     // Checks and adjust the selection range
     // Return FALSE if there are no rows in the block range
     BOOL _CheckBlockRange(int nRowsCount, int& ib, int& ie);


     // Checks if the selection would change from current
     BOOL WillSelectionChange(int& ib, int& ie, BOOL bSelect);


     // Centralized method that handle all cases and that should be called for every changes in the selection
     // In this method, we check the range, and we know if we are clearing the selection, changing the selection of only one item, ...
     // Should return TRUE if the selection has changed from current, if not, return FALSE and do not notify or redraw
     BOOL ChangeSelection(int& ib, int& ie, BOOL bSelect, BOOL bNotify, BOOL bRedraw);


CXTPReportControl

Keyboard events or mouse events should call a centralized method to manage the selection.


     // To know from where we extend the selection
     // Used for mouse and keyboard
     // -1 = no selection extend = no item previously selected
     int m_nSelExtendStartingRowIndex = -1;


     // Centralized method to manage the selection
     // All the checks must be made in this method
     // Returns TRUE if the selection has changed, to be able to notify or update display later
     BOOL DoSelectionChange(int nNewlyFocusedRowIndex, BOOL bExtendTo /*if VK_SHIFT*/, BOOL bReplacePreviousSelection /*if not VK_CONTROL*/, BOOL bByMouse, BOOL bSpacebarPressed /*If not by mouse, if VK_SPACE pressed to switch row selection*/, BOOL bNotify, BOOL bUpdateDisplay)

     Implementation :

     // Keyboard - bByMouse=FALSE

     // Always do this check and change
     if m_nSelExtendStartingRowIndex==-1 and bSpacebarPressed!=TRUE
     then bExtendTo=FALSE

     if bSpacebarPressed==FALSE

          if bExtendTo==FALSE
          and bReplacePreviousSelection==TRUE
          then clear the selection
          and select nNewlyFocusedRowIndex
          and m_nSelExtendStartingRowIndex=nNewlyFocusedRowIndex

          if bExtendTo==TRUE
          and bReplacePreviousSelection==TRUE
          then clear the selection
          and select bloc from m_nSelExtendStartingRowIndex to nNewlyFocusedRowIndex
          do not change m_nSelExtendStartingRowIndex!

          if bExtendTo==FALSE
          and bReplacePreviousSelection==FALSE
          then set only the FOCUS CARET to nNewlyFocusedRowIndex
          and m_nSelExtendStartingRowIndex=nNewlyFocusedRowIndex
          Do not make any change to the selection !

          if bExtendTo==TRUE
          and bReplacePreviousSelection==FALSE
          then select bloc from m_nSelExtendStartingRowIndex to nNewlyFocusedRowIndex
          do not change m_nSelExtendStartingRowIndex!

     if bSpacebarPressed==TRUE

          if bExtendTo==FALSE
          and bReplacePreviousSelection==TRUE
          then do nothing !

          if bExtendTo==TRUE
          and bReplacePreviousSelection==TRUE
          then do nothing !

          if bExtendTo==FALSE
          and bReplacePreviousSelection==FALSE
          then invert the selection of nNewlyFocusedRowIndex
          and m_nSelExtendStartingRowIndex=nNewlyFocusedRowIndex

          if bExtendTo==TRUE
          and bReplacePreviousSelection==FALSE
          then clear the selection
          and select nNewlyFocusedRowIndex
          and m_nSelExtendStartingRowIndex=nNewlyFocusedRowIndex



     // Mouse - bByMouse=TRUE

     // Always do this check and change
     if m_nSelExtendStartingRowIndex==-1
     then bExtendTo=FALSE

     if bExtendTo==FALSE
     and bReplacePreviousSelection==TRUE
     then clear the selection
     and select nNewlyFocusedRowIndex
     and m_nSelExtendStartingRowIndex=nNewlyFocusedRowIndex

     if bExtendTo==TRUE
     and bReplacePreviousSelection==TRUE
     then clear the selection
     and select bloc from m_nSelExtendStartingRowIndex to nNewlyFocusedRowIndex
     do not change m_nSelExtendStartingRowIndex!

     if bExtendTo==FALSE
     and bReplacePreviousSelection==FALSE
     then invert the selection of nNewlyFocusedRowIndex
     and m_nSelExtendStartingRowIndex=nNewlyFocusedRowIndex

     if bExtendTo==TRUE
     and bReplacePreviousSelection==FALSE
     then select bloc from m_nSelExtendStartingRowIndex to nNewlyFocusedRowIndex
     do not change m_nSelExtendStartingRowIndex!


It's a little difficult to know how the code in the Codejock ToolKitPro works, but I think this will help !