CXTRegistryManager suggestion

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

Suggestion #1
Sometimes you want registry keys to always be present in the registry. This makes it easier for users to edit some special settings!

I think you should have an extra parameter in the CXTRegistryManager constructor:

BOOL bPersistentValues = TRUE;
CXTRegistryManager reg(HKEY_LOCAL_MACHINE, bPersistentValues);
int value = reg.GetProfileInt("Settings", "Value", 0);

After the call to GetProfileInt, the key/value will be created, hence readable by a user!

This behavior is disencouraged most of the time, so the second parameter should default to FALSE!

Suggestion #2
Also, I think it should be possible to set the registry key and profile name directly in the constructor. We have multiple products accessing each other's profiles, and it would be very convenient if you could type the following:

CXTRegistryManager reg(HKEY_LOCAL_MACHINE, TRUE);
and a second constructor:

CXTRegistryManager reg(HKEY_LOCAL_MACHINE, "RegistryKey", "ProfileName", TRUE);

The code gets bloated if you need to call SetRegistryKey (or similar) all the time!

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
znakeeye Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 26 July 2006 Status: Offline Points: 1672	Post Options Post Reply Quote znakeeye Report Post Thanks(0) Quote Reply Topic: CXTRegistryManager suggestion Posted: 25 November 2008 at 5:00am
	Suggestion #1 Sometimes you want registry keys to always be present in the registry. This makes it easier for users to edit some special settings! I think you should have an extra parameter in the CXTRegistryManager constructor: BOOL bPersistentValues = TRUE; CXTRegistryManager reg(HKEY_LOCAL_MACHINE, bPersistentValues); int value = reg.GetProfileInt("Settings", "Value", 0); After the call to GetProfileInt, the key/value will be created, hence readable by a user! This behavior is disencouraged most of the time, so the second parameter should default to FALSE! Suggestion #2 Also, I think it should be possible to set the registry key and profile name directly in the constructor. We have multiple products accessing each other's profiles, and it would be very convenient if you could type the following: CXTRegistryManager reg(HKEY_LOCAL_MACHINE, TRUE); and a second constructor: CXTRegistryManager reg(HKEY_LOCAL_MACHINE, "RegistryKey", "ProfileName", TRUE); The code gets bloated if you need to call SetRegistryKey (or similar) all the time!
	PokerMemento - http://www.pokermemento.com/

Oleg Members Profile Send Private Message Find Members Posts Add to Buddy List Admin Group Joined: 21 May 2003 Location: United States Status: Offline Points: 11234	Post Options Post Reply Quote Oleg Report Post Thanks(0) Quote Reply Posted: 25 November 2008 at 7:13am
	Hi, 1. its easy to emulate it: int nValue = reg.GetProfileInt("Settings", "Value", -1); if (nValue == -1) reg.WriteProfileInt("Settings", "Value", 0), nValue = 0;
	Oleg, Support Team CODEJOCK SOFTWARE SOLUTIONS

znakeeye Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 26 July 2006 Status: Offline Points: 1672	Post Options Post Reply Quote znakeeye Report Post Thanks(0) Quote Reply Posted: 25 November 2008 at 8:42am
	1. Yes, but the code code be cleaner ;) 2. ? :)
	PokerMemento - http://www.pokermemento.com/

Oleg Members Profile Send Private Message Find Members Posts Add to Buddy List Admin Group Joined: 21 May 2003 Location: United States Status: Offline Points: 11234	Post Options Post Reply Quote Oleg Report Post Thanks(0) Quote Reply Posted: 26 November 2008 at 3:16am
	Hi, To create cleaner code add 2 members GetProfileInt and WriteProfileInt and call CXTRegistryManager + future SetRegistryKey + reg.GetProfileInt/reg.WriteProfileInt .
	Oleg, Support Team CODEJOCK SOFTWARE SOLUTIONS