Multiple ranged selection not working

What do you like to reach? Select non-continues set of Rows? It's works - with Ctrl+Click. Or you need discrete set of Cells?

BOOL m_bMultiSelectionMode; // TRUE if multiselection mode enabled (i.e. VK_CTRL is always on).

This is same concept as any listbox or list control non-continues selection - it collect set of items as ONE subset. You can do smth yourself with this subset - e.g. keep it in your own container. Now you can have many subsets. Current release 13 has no differences with release 12 in this spec.

OK - confirmed. Will fix in Release 13.1

Have

Hello Mark,

We just tested your executable and it needs some fixes :

1) In some cases, when the items are displayed for example in group, the CTRL + SHIFT doesn't select the last clicked line. When the CTRL + SHIFT keys are used, all items in the clicked range should always be selected, including the first one and the last one.

2) When displaying items in group, the group titles in the range are not selected (but the first and the last are selected!). Group titles cannot anyway be selected by using the keyboard. It's a little strange.

3) In some cases, the simple selection of a range of items (just by using the SHIFT key with a mouse click or up/down arrow keys) doesn't work upward. For example, go to the middle of the Report Control, then hold down the shift key and move up (by the up key or a mouse click) to backward select a range of items. It doesn't occur when displaying items in group.

4) Using the CTRL key without the SHIFT key should not take care of any range, it should just invert the selection of the clicked item. You have some other bugs here but they are linked to the point (3).

----------------

NB: Your WYSIWYG print mode doesn't work for the last column (the size of the last printed column is extra big). When removing the WYSIWYG print mode, in your sample app, you shoud redraw the Report Control.

----------------

Hope you will fix.

Regards,

When you turn off the WYSIWYG mode, the little red markers are still visible.

In WYSIWYG mode, the last column is always on a new page ?

OK, now it works, you fixed them both.

Please let me know when the selection will be fixed.

Hi, check this static app - https://forum.codejock.com/uploads/DemoVersion/ReportSampleSatic.rar

OK - but when I write about mouse selection fixed (up and down direction) I mean actions:

It means:

BOOL bIgnoreSelection = GetKeyState(VK_CONTROL) < 0 || IsMultiSelectionMode();

BOOL bSelectBlock = GetKeyState(VK_SHIFT) < 0;

if (bIgnoreSelection) //Ctrl disable Shift!

bSelectBlock = FALSE;

For mouse selection I think this is a good feature - you don't need to release SHIFT key - just press CTRL and you can select next block.

Without it next click will extend previous selection - so no differences with and without CONTROL

 

Sure - please

Please make all situations testing and give your comments after

No - this control from .\CodejockSVN\Samples\Controls\ListCtrl

I'm currently checking your code, I will then send you the modified files. Do you have a file comparer ? If not, you can use Beyond Compare for 30 days (www.scootersoftware.com).

Please note that I have also fixed the horizontal scrollbar to 32 bits (without any impacts for you and customers).

Meanwhile, can you please add and implement these two methods in your class :


XTPReportView.h
===============

     //-----------------------------------------------------------------------
     // Summary:
     //     This method is called to print the page header of the report control
     // Parameters:
     //     pDC              - Print device context
     //     rcPage           - Page print area
     //     bOnlyCalculate   - TRUE = only calculate
     //                        FALSE = calculate and print
     // Returns:
     //     The header height in device units.
     //-----------------------------------------------------------------------
     virtual int PrintPageHeader(CDC* pDC, CPrintInfo* pInfo, CRect rcPage, BOOL bOnlyCalculate, int nPageNumber, int nNumberOfPages);

     //-----------------------------------------------------------------------
     // Summary:
     //     This method is called to print the page footer of the report control
     // Parameters:
     //     pDC              - Print device context
     //     rcPage           - Page print area
     //     bOnlyCalculate   - TRUE = only calculate
     //                        FALSE = calculate and print
     // Returns:
     //     The footer height in device units.
     //-----------------------------------------------------------------------
     virtual int PrintPageFooter(CDC* pDC, CPrintInfo* pInfo, CRect rcPage, BOOL bOnlyCalculate, int nPageNumber, int nNumberOfPages);


XTPReportView.cpp
=================

// New method
int CXTPReportView::PrintPageHeader(CDC* pDC, CPrintInfo* pInfo, CRect rcPage, BOOL bOnlyCalculate, int nPageNumber, int nNumberOfPages)
{
     int nHeaderHeight = 0;

     if (GetReportCtrl().IsHeaderVisible())
          nHeaderHeight = GetPaintManager()->GetHeaderHeight(&GetReportCtrl(), pDC, rcPage.Width()-2);

     CRect rcHeader(rcPage.left + 1, rcPage.top + 1, rcPage.right - 1, rcPage.top + 1 + nHeaderHeight);

     if (nHeaderHeight)
          PrintHeader(pDC, rcHeader);

     return nHeaderHeight;

     // Customer implementation example :

     //int nTestHeight = rcPage.Height() / 10;
     //CRect rTest(rcPage);
     //rTest.bottom = rTest.top + nTestHeight;

     //pDC->FillSolidRect(rTest, RGB(0,0,0));
     //rTest.DeflateRect(1,1);
     //pDC->FillSolidRect(rTest, RGB(128,128,255));
     //rTest.DeflateRect(10,10);
     //pDC->DrawText(_T("Test Header"), rTest, DT_CENTER | DT_VCENTER | DT_SINGLELINE);

     //return nTestHeight;
}

// New method
int CXTPReportView::PrintPageFooter(CDC* pDC, CPrintInfo* pInfo, CRect rcPage, BOOL bOnlyCalculate, int nPageNumber, int nNumberOfPages)
{
     int nFooterHeight = 0;

     if (GetReportCtrl().IsFooterVisible())
          nFooterHeight = GetPaintManager()->GetFooterHeight(&GetReportCtrl(), pDC, rcPage.Width()-2);

     CRect rcFooter(rcPage.left + 1, rcPage.bottom - nFooterHeight - 1, rcPage.right - 1, rcPage.bottom - 1);

     if (nFooterHeight)
          PrintFooter(pDC, rcFooter);

     return nFooterHeight;
}

long CXTPReportView::PrintReport(CDC* pDC, CPrintInfo* /*pInfo*/, CRect rcPage, long nIndexStart)
{
     int nPageNumber = ...;
     int nNumberOfPages = ...;

     int nHeaderHeight = PrintPageHeader(pDC, pInfo, rcPage, FALSE, nPageNumber, nNumberOfPages);

     int nFooterHeight = PrintPageFooter(pDC, pInfo, rcPage, FALSE, nPageNumber, nNumberOfPages);

     CRect rcRows(rcPage.left + 1, rcPage.top + 1 + nHeaderHeight, rcPage.right - 1, (rcPage.bottom - 1) - nFooterHeight);

     ...


With these two methods, we add more flexibility to customize the print. The page header's and footer's height can be set more easily without having to override from CXTPReportPaintManager.

Ok. I will do the changes (and add horizontal pages support). I hope that we have no conflicts with our changes.

I cannot test my changes due to our configuration, I will post the files and then check your new build.

I'm currently looking at the method CXTPReportControl::SetFocusedRow(...), which seems to be responsible of a bug.

Here's part one of two, all these changes should be checked after your build :

20090527_084025_ForSergioChange.zip


CXTPReportControl

- Fixed 16 bits range of horizontal scrollbar
- Fixed unselected clicked row for ranged selection (CTRL + SHIFT + CLICK for a backward selection)


CXTPReportPaintManager

- Added "BOOL m_bPrintPageRectangle" to be able to hide pages borders


CXTPReportView

- Added two new virtual methods :

     virtual int PrintPageHeader(CDC* pDC, CPrintInfo* pInfo, CRect rcPage, BOOL bOnlyCalculate, int nPageNumber, int nNumberOfPages, int nHorizontalPageNumber, int nNumberOfHorizontalPages);

     virtual int PrintPageFooter(CDC* pDC, CPrintInfo* pInfo, CRect rcPage, BOOL bOnlyCalculate, int nPageNumber, int nNumberOfPages, int nHorizontalPageNumber, int nNumberOfHorizontalPages);

- Changed : "int x(0), y(0);" to "int x = 0, y = 0;"

___________________

I have implemented all the code, but you will perhaps have some compiler errors because I can't build the sources on my computer. Please let me know...

I am still checking for SetFocusedRow(...) to fix another problem with ranged selection.

Now, please include my sources into yours, rebuild and update the executable. I will then check if it works.

Thank you.

I refresh samples so you can try now

Print will print exact pages (you can try print in file, e,g use MS ImageWriter) - I am keeping printpreview unrestricted for now - this is not dengerous/ Later today will restrict to existed pages only

this is fix for your scroll code

Yes, you're right, you fixed the scrollbar, it's ok now, thank you.

I didn't fix the selection (only one case, but it didn't work at all, that's the line you commented), I said "Here's part one of two"...

I will now focus only on the selection !

Have you updated the sources ?

Ok, I will try to compile the sources on my computer in order to be able to debug the selection.

Is it possible to put your files into the Codejock Version 12.0.1? Will it build successfully?

I've just read your answer, but now, I must leave the office.

I have downloaded and installed the ToolKitPro version 13.0.0.

Tomorrow, I'll merge the new sources and finally try to build and test the selection and what you say.

See you tomorrow and have a nice afternoon.

Hi Mark,

I'm trying to build the Codejock ToolKitPro 13.0.0 with all your new files (Report Control + Common), but I need some more files :

error C2027: use of undefined type 'CXTPReportRecordItemIcon'     g:\dev\codejock software\mfc\xtreme toolkitpro v13.0.0\source\reportcontrol\xtpreportrecorditemtext.cpp     44
...
error C2027: use of undefined type 'CXTPReportRecordItemIcon'     g:\dev\codejock software\mfc\xtreme toolkitpro v13.0.0\source\reportcontrol\xtpreportrecorditemtext.cpp     161
error C2039: 'GetParentRecord' : is not a member of 'CXTPReportRecord'     g:\dev\codejock software\mfc\xtreme toolkitpro v13.0.0\source\reportcontrol\xtpreportcontrol.cpp     4584
error C2039: 'GetParentRecord' : is not a member of 'CXTPReportRecord'     g:\dev\codejock software\mfc\xtreme toolkitpro v13.0.0\source\reportcontrol\xtpreportrecord.cpp     283
error C2059: syntax error : ')'     g:\dev\codejock software\mfc\xtreme toolkitpro v13.0.0\source\reportcontrol\xtpreportrecorditemtext.cpp     46
error C2059: syntax error : ')'     g:\dev\codejock software\mfc\xtreme toolkitpro v13.0.0\source\reportcontrol\xtpreportrecorditemtext.cpp     46
error C2061: syntax error : identifier 'CXTPReportRecordItemIcon'     g:\dev\codejock software\mfc\xtreme toolkitpro v13.0.0\source\reportcontrol\xtpreportrecorditemtext.cpp     44
error C2061: syntax error : identifier 'CXTPReportRecordItemIcon'     g:\dev\codejock software\mfc\xtreme toolkitpro v13.0.0\source\reportcontrol\xtpreportrow.cpp     317
error C2065: 'm_pRecords' : undeclared identifier     g:\dev\codejock software\mfc\xtreme toolkitpro v13.0.0\source\reportcontrol\xtpreportrecord.cpp     285
error C2065: 'm_pRecords' : undeclared identifier     g:\dev\codejock software\mfc\xtreme toolkitpro v13.0.0\source\reportcontrol\xtpreportrecord.cpp     285
error C2065: 'm_pRecords' : undeclared identifier     g:\dev\codejock software\mfc\xtreme toolkitpro v13.0.0\source\reportcontrol\xtpreportrecord.cpp     286
error C2143: syntax error : missing ';' before '{'     g:\dev\codejock software\mfc\xtreme toolkitpro v13.0.0\source\reportcontrol\xtpreportrecorditemtext.cpp     47
error C2227: left of '->GetOwnerRecord' must point to class/struct/union/generic type     g:\dev\codejock software\mfc\xtreme toolkitpro v13.0.0\source\reportcontrol\xtpreportrecord.cpp     285
error C2227: left of '->GetOwnerRecord' must point to class/struct/union/generic type     g:\dev\codejock software\mfc\xtreme toolkitpro v13.0.0\source\reportcontrol\xtpreportrecord.cpp     286
error C2270: 'GetParentRecord' : modifiers not allowed on nonmember functions     g:\dev\codejock software\mfc\xtreme toolkitpro v13.0.0\source\reportcontrol\xtpreportrecord.cpp     284
error C2270: 'GetRuntimeClass' : modifiers not allowed on nonmember functions     g:\dev\codejock software\mfc\xtreme toolkitpro v13.0.0\source\reportcontrol\xtpreportrecorditemtext.cpp     44
error C2352: 'CXTPReportRecordItem::Draw' : illegal call of non-static member function     g:\dev\codejock software\mfc\xtreme toolkitpro v13.0.0\source\reportcontrol\xtpreportrecorditemtext.cpp     54
error C2352: 'CXTPReportRecordItem::Draw' : illegal call of non-static member function     g:\dev\codejock software\mfc\xtreme toolkitpro v13.0.0\source\reportcontrol\xtpreportrecorditemtext.cpp     63
error C2352: 'CXTPReportRecordItem::GetCaptionRect' : illegal call of non-static member function     g:\dev\codejock software\mfc\xtreme toolkitpro v13.0.0\source\reportcontrol\xtpreportrecorditemtext.cpp     157
error C2352: 'CXTPReportRecordItem::OnDrawCaption' : illegal call of non-static member function     g:\dev\codejock software\mfc\xtreme toolkitpro v13.0.0\source\reportcontrol\xtpreportrecorditemtext.cpp     132
error C2352: 'CXTPReportRecordItem::OnEditChanged' : illegal call of non-static member function     g:\dev\codejock software\mfc\xtreme toolkitpro v13.0.0\source\reportcontrol\xtpreportrecorditemtext.cpp     166
error C2447: '{' : missing function header (old-style formal list?)     g:\dev\codejock software\mfc\xtreme toolkitpro v13.0.0\source\reportcontrol\xtpreportrecorditemtext.cpp     47
error C2653: 'CXTPReportRecordItemIcon' : is not a class or namespace name     g:\dev\codejock software\mfc\xtreme toolkitpro v13.0.0\source\reportcontrol\xtpreportrecorditemtext.cpp     44
error C2653: 'CXTPReportRecordItemIcon' : is not a class or namespace name     g:\dev\codejock software\mfc\xtreme toolkitpro v13.0.0\source\reportcontrol\xtpreportrecorditemtext.cpp     44
error C2653: 'CXTPReportRecordItemIcon' : is not a class or namespace name     g:\dev\codejock software\mfc\xtreme toolkitpro v13.0.0\source\reportcontrol\xtpreportrecorditemtext.cpp     44
fatal error C1903: unable to recover from previous error(s); stopping compilation     g:\dev\codejock software\mfc\xtreme toolkitpro v13.0.0\source\reportcontrol\xtpreportcontrol.cpp     4584

Please help !

It's all right ! The Codejock ToolKitPro now compile perfectly.

Next step : I must try to compile your "ReportSampleMod.rar" project.

Could you please give me some explanation for the member variable m_iSelectOnMouseUpRow?

OK, so you have two member variables for identifying the current bloc selection range : m_iSelectOnMouseUpRow and m_iSelectOnKeyUpRow, one for the mouse and another one for the keyboard.

On next Tuesday (because on next Monday it's holiday) I will check them and make a small resume of how should the code work.

Hi, Sergio - no need to invent wheels - take a look in MFC Grid 2.26 - http://www.codeproject.com/KB/miscctrl/gridctrl.aspx it use proper way for mouse-based selection (but restricted for keyboard-based) so try to implement similar concept - don't use existed implementation of

SELECTED_BLOCK - it works for expand - collapse case now but we can use better approach for selection. I am busy now with many other things to finalize 13.1 so I like you conventrate on this isolate task and finish it soon - this is not difficult just be accurate and cover all cases. We can also start to use real blocks (x start, y start, x end, y end) keeping in mind future (like CJ Grid  Control instead of CJ Report Control).

 

https://forum.codejock.com/uploads/DemoVersion/ForSergio.rar

Sorry - done

The only place I want to keep old code is expand-collapse parent-childs combination - this is isolated case and not related to selection.

You can also use https://forum.codejock.com/uploads/DemoVersion/ReportSampleSourceUpdated.rar and check 32bit scrollbars for External Themed scrollbars - you will see they works but not in 32bit mode while internal scrollbar did

OK, I have done 75 % of the work. But now, I can't compile your new sources for the sample app., because :

reportsampleview.cpp(378) : error C2660: 'CXTPReportView::SetScrollBarCtrl' : function does not take 2 arguments
reportsampleview.cpp(432) : error C2660: 'CXTPReportControl::AssignIconViewPropNumAndIconNum' : function does not take 4 arguments
reportsampleview.cpp(577) : error C2039: 'm_iCheckWithRightButton' : is not a member of 'CXTPReportControl'
reportsampleview.cpp(578) : error C2039: 'm_iCheckRightButtonExtended' : is not a member of 'CXTPReportControl'

I think I need to update ToolKitPro sources, so could you please tell me which link belongs to ToolKitPro sources ?

I will then also check for external scrollbars.

btw - I like to have dynamic stateless logic without any crutches (like keyboard or mouse direction like 

Still need to be fixed :

- External scrollbars (Please tell me more about these ones, how are they attached to the report control?)

- m_iSelectOnMouseUpRow, m_iSelectOnKeyUpRow : I must now fill them in the correct place, the starting ranges are now incorrect.

- Expand/Collapse : now collapsed items keep their selected state (but when collapsed the CXTPReportSelectedRows doesn't know that they are selected) ---> Tell me if you like this behaviour, I will then change the code in CXTPReportSelectedRows::_OnExpanded(...)/_OnCollapsed(...)

Make a build - mouse selection looks like works, keyboard - not. VirtualMode show all rows selected on start?! Think about this case - I guess this is result of your state stored value which for virtual mode is one for all?!

Arron - this is exactly that you can find in published code:

Please note that I have no more time to consecrate to this task, I have to do my own job. I will still check your samples .exe and your feedbacks, but I must now switch back to my development environment. Please kindly note that you don't pay us for this task, we do it...

If you get back to block selection, don't forget to put the code back to the methods _OnExpanded()/_OnCollapsed()...

Thank you.

OK - you proposed your help and now you refused to finish with comments about pay - so I will ignore you changes and will do my own implementation later as now we are going to release version and I have no time (the reason I agree for your help) to fix old wrong design - only improve it little bit

Deadlines as always - yesterday, in current case this is not a figure of speech but pure true. Release should be today. But you can try to fix your vision of selection - if it will be good and work properly in all cases - I will try to use it. Look on current state in static app - refreshed but keeped same link

OK - let's finish it later. I also busy now and this "bug" is minor - if user can't make desired selection using one way - he can do it using another way...

Hi Mark,

I don't know, I'm waiting for a response from my manager.

Meanwhile, could you please fix this method in the CXTResize::Size() :


     void CXTResize::Size()
     {
          if (m_arrItems.GetSize() > 0)
          {
               CSize szWindow = CXTPClientRect(m_pWnd).Size();
               if (szWindow.cx == 0 || szWindow.cy == 0)
                    return;

               //////////////////////////
               // New Code - Begin - take care of limits
               if (m_szMin.cx != 0)
                    szWindow.cx = max(m_szMin.cx, szWindow.cx);

               if (m_szMin.cy != 0)
                    szWindow.cy = max(m_szMin.cy, szWindow.cy);

               if (m_szMax.cx != 0)
                    szWindow.cx = min(m_szMax.cx, szWindow.cx);

               if (m_szMax.cy != 0)
                    szWindow.cy = min(m_szMax.cy, szWindow.cy);
               // New Code - End - take care of limits
               //////////////////////////

               AjustResizeRect(szWindow);

               CSize szDelta = szWindow - m_szWindow;

               HDWP hDWP = ::BeginDeferWindowPos((int)m_arrItems.GetSize());

               ...


We are using this class for a child window (no WM_GETMINMAXINFO).

Thank you in advance,
Regards.

If you get recent official version of MFC code - you can start from here

Download OK. I will launch the setup on next Monday.

Hi Mark,

Thank you for having included all the small enhancements.

I am currently using your release version 13.1.0 and successfully built one of our projects.

I will keep you informed as soon as I have tested your ReportControlMFCUpdated.rar files.

Best regards,

Please re-build using recent updates and confirm as I don't have such effect. Could you reproduce it on

 

https://forum.codejock.com/uploads/DemoVersion/ReportSampleStatic.rar

I don't understand - are we using same code or not?

Latest release is not that I mean - you need to get updates from https://forum.codejock.com/uploads/DemoVersion/ReportControlMFCUpdated.rar

You are doing smth sensless as scrolling code changed

this is why I propose you to use patch and we can fix fullcolumnscroll case faster using same code

Fresh demo with persist child selection here - https://forum.codejock.com/uploads/DemoVersion/ReportSampleStaticProto.rar