Bugs in CXTPOffice2003Theme

I doubt Codejock considers these "bugs" really. I do have more updates to my Ex classes which fix more of the things above such as the separators, but I always like the blue oclor in Windows 2000.

Thanks very much, Oleg.

I'm very happy with the way the problems i report get fixed by XTP.

Do you know when 9.81 will be out?

or is there a hotfix for these problems?

Dmitry.

I hope in next week we will release it.

Disabled icons look nearly exactly like Office 2003 now.

Does CXTPImageManager::m_dDisabledBrightnessFactor or CXTPImageManager::m_dDisabledAlphaFactor have any effect anymore then? I would think they still should, if a user wants to tweak the disable-generation method still.

I noticed the disabled *text* is now just grey, instead of a theme-matching color. Why is that?

I like the icons to match Office, so that is all fine. I just thought it would be useful to some people to still be able to tweak the OfficeStyleDisabledIcons using at least m_dDisabledAlphaFactor to darken/lighten them a little still.

I noticed the bars and colors generally became lighter for some colors, to more closely match Office 2003 too.
You are right, Office 2003 does use grey disabled text. It doesn't look as nice as the colored disabled text, but it should match Office 2003 I think, so that is fine as well.

Yes, sorry, we changed it, and yes some colors are switched to allow call:

XTPDrawHelpers()->GradientFill(pDC, rcFill, m_clrDockBar, TRUE, rc);

So really it is not light/dark, but left/right.

ok, thanks, we will check how it looks with Window Blinds/Style XP

Here is how ugly it looks :)



Btw, in non-Luna the customize dialog has the right edge cut off the checkboxes:

Hmm about "right edge cut off the checkboxes"   you tested it with win2k?

Just checked with XP and 2000 and don't see it....

Actually it is CCheckBox from MFC without any modifications.... Microsoft... you know....

When compiling the XTPDocingPaneOffice2003ThemeEx.cpp and XTPOffice2003ThemeEx.cpp under Codejock Toolkit 9.81, I get the following errors:

XTPDockingPaneOffice2003ThemeEx.cpp
CXTPDockingPaneOffice2003ThemeEx.cpp(19) : error C2065: 'm_clrActiveCaptionDark' : undeclared identifier
XTPDockingPaneOffice2003ThemeEx.cpp(20) : error C2065: 'm_clrActiveCaptionLight' : undeclared identifier
XTPDockingPaneOffice2003ThemeEx.cpp(21) : error C2065: 'm_clrNormalCaptionDark' : undeclared identifier
XTPDockingPaneOffice2003ThemeEx.cpp(22) : error C2065: 'm_clrNormalCaptionLight' : undeclared identifier

XTPOffice2003ThemeEx.cpp
XTPOffice2003ThemeEx.cpp(18) : error C2065: 'm_clrDockBarDark' : undeclared identifier
XTPOffice2003ThemeEx.cpp(19) : error C2065: 'm_clrDockBarLight' : undeclared identifier
XTPOffice2003ThemeEx.cpp(20) : error C2065: 'm_clrCommandBarDark' : undeclared identifier
XTPOffice2003ThemeEx.cpp(21) : error C2065: 'm_clrCommandBarLight' : undeclared identifier
XTPOffice2003ThemeEx.cpp(22) : error C2065: 'm_clrPopupDark' : undeclared identifier
XTPOffice2003ThemeEx.cpp(23) : error C2065: 'm_clrPopupLight' : undeclared identifier
XTPOffice2003ThemeEx.cpp(24) : error C2065: 'm_crlToolbarShadow' : undeclared identifier
XTPOffice2003ThemeEx.cpp(25) : error C2065: 'm_crlFloatingGripper' : undeclared identifier
XTPOffice2003ThemeEx.cpp(26) : error C2065: 'm_crlExpandNormalDark' : undeclared identifier
XTPOffice2003ThemeEx.cpp(27) : error C2065: 'm_crlExpandNormalLight' : undeclared identifier
XTPOffice2003ThemeEx.cpp(28) : error C2065: 'm_clrMenuExpandedDark' : undeclared identifier
XTPOffice2003ThemeEx.cpp(29) : error C2065: 'm_clrMenuExpandedLight' : undeclared identifier
XTPOffice2003ThemeEx.cpp(30) : error C2065: 'm_clrCircleDark' : undeclared identifier
XTPOffice2003ThemeEx.cpp(31) : error C2065: 'm_clrCircleLight' : undeclared identifier
XTPOffice2003ThemeEx.cpp(127) : error C2039: 'GetRawRect' : is not a member of 'CXTPControl'

Do anyone have updated files that are working with Codejock Toolkit 9.81?

Actually in some old version was added

pCommandBars->GetPaintManager()->SetLunaTheme(xtpSyste mThemeBlue); - to make Blue theme for CommandBars only and

XTPColorManager()->SetLunaTheme(xtpSystemThemeBlue); for all controls.

But repeat again. I and Microsoft :) don't recommend do it. Blue theme with non Blue Frame/ScrollBars/Controls looks ugly.

 

Tried to replace the following code in your Wordpad example (Office 11):

    CXTPPaintManager::SetTheme(xtpThemeOffice2003);

with

    XTPColorManager()->SetLunaTheme(xtpSystemThemeBlue);

but then all blue colors disappeared - also in Windows XP.
Do the SetLunaTheme functiona work at all - in case how?

How do I get the blue Office 2003 colors in both Windows XP and Windows 2000?

I can't see that the SetLunaTheme is resulting any Office 2003 look in Windows 2000 (the Office 2003 Windows XP look - the blue look), so I am still using your classes.

What about the other classes - i get compiler errors in the following classes with Toolkit Pro 9.81 (as seen above):
    CXTPDockingPaneOffice2003ThemeEx
    CXTPOffice2003ThemeEx

Please send me CXTPDockingPaneOffice2003ThemeEx as well!

Thanks!

class CXTPDockingPaneOffice2003ThemeEx : public CXTPDockingPaneOffice2003Theme
{
public:
    CXTPDockingPaneOffice2003ThemeEx(BOOL bGreyToBlue = TRUE);
    BOOL m_bGreyToBlue;
protected:
    virtual void RefreshMetrics();
};

class CColorSetOffice2003Ex : public CXTPTabPaintManager::CColorSetOffice2003
{
public:
    CColorSetOffice2003Ex(BOOL bGreyToBlue = TRUE);
    virtual COLORREF FillClient(CDC* pDC, CRect rc, CXTPTabManager* pTabManager);
    BOOL m_bGreyToBlue;
protected:
    virtual void RefreshMetrics();
};

----------------------------------------------------

CXTPDockingPaneOffice2003ThemeEx::CXTPDockingPaneOffice2003T hemeEx(BOOL bGreyToBlue)
{
    m_bGreyToBlue = bGreyToBlue;
    RefreshMetrics();

    m_pTabPaintManager->SetAppearance(xtpTabAppearancePropert yPage2003);
    m_pTabPaintManager->SetColorSet(new CColorSetOffice2003Ex(bGreyToBlue));
    m_pPanelPaintManager->SetAppearance(xtpTabAppearancePrope rtyPage2003);
    m_pPanelPaintManager->SetColorSet(new CColorSetOffice2003Ex(bGreyToBlue));
}

void CXTPDockingPaneOffice2003ThemeEx::RefreshMetrics()
{
    CXTPDockingPaneOffice2003Theme::RefreshMetrics();

    if( !m_bLunaTheme ) {
        CXTPColorManager *pClrMgr = XTPColorManager();
        COLORREF btn = pClrMgr->GetColor(COLOR_BTNFACE);
        if( m_bGreyToBlue && (btn == RGB(192, 192, 192) || btn == RGB(212, 208, 200) || btn == RGB(235, 233, 237)) ) {
            m_clrNormalCaption.clrDark = RGB(129, 169, 226);
            m_clrNormalCaption.clrLight = RGB(221, 236, 254);
            m_clrNormalCaption.fGradientFactor = 0.75f;
            m_clrActiveCaption.clrDark = RGB(255, 166, 76);
            m_clrActiveCaption.clrLight = RGB(255, 213, 140);
            m_clrActiveCaption.fGradientFactor = 0.50f;
            m_clrNormalCaptionText = RGB(0, 0, 0);
            m_clrActiveCaptionText = RGB(0, 0, 0);
            m_clrSplitterGripper = RGB(191, 188, 177);
            m_clrSplitter = RGB(216, 231, 252);
            m_clrSplitterGradient.clrDark = RGB(196, 218, 250);
            m_clrSplitterGradient.clrLight = RGB(158, 190, 245);
            m_clrSplitterGradient.fGradientFactor = 0.50f;
            m_bLunaTheme = TRUE;

            m_arrColor[0] = RGB(0, 0, 0);
            m_arrColor[1] = RGB(0, 78, 152);
            m_arrColor[2] = RGB(0, 84, 227);
            m_arrColor[3] = RGB(122, 150, 223);
            m_arrColor[4] = RGB(255, 255, 255);
            m_arrColor[5] = RGB(255, 255, 255);
            m_arrColor[6] = RGB(0, 0, 0);
            m_arrColor[7] = RGB(0, 0, 0);
            m_arrColor[8] = RGB(0, 0, 0);
            m_arrColor[9] = RGB(255, 255, 255);
            m_arrColor[10] = RGB(212, 208, 200);
            m_arrColor[11] = RGB(212, 208, 200);
            m_arrColor[12] = RGB(128, 128, 128);
            m_arrColor[13] = RGB(49, 106, 197);
            m_arrColor[14] = RGB(255, 255, 255);
//            m_arrColor[15] = RGB(236, 233, 216);
            m_arrColor[15] = btn;
            m_arrColor[16] = RGB(172, 168, 153);
            m_arrColor[17] = RGB(172, 168, 153);
            m_arrColor[18] = RGB(0, 0, 0);
            m_arrColor[19] = RGB(216, 228, 248);
            m_arrColor[20] = RGB(255, 255, 255);
            m_arrColor[21] = RGB(113, 111, 100);
            m_arrColor[22] = RGB(251, 248, 231);
            m_arrColor[23] = RGB(0, 0, 0);
            m_arrColor[24] = RGB(255, 255, 225);
            m_arrColor[25] = RGB(181, 181, 181);
            m_arrColor[26] = RGB(0, 0, 128);
            m_arrColor[27] = RGB(61, 149, 255);
            m_arrColor[28] = RGB(0, 0, 0);
            m_arrColor[29] = RGB(0, 0, 0);
            m_arrColor[30] = RGB(158, 190, 245);
            m_arrColor[31] = RGB(255, 238, 194);
            m_arrColor[32] = RGB(0, 0, 128);
            m_arrColor[33] = RGB(254, 128, 62);
            m_arrColor[34] = RGB(144, 157, 178);
            m_arrColor[35] = RGB(197, 194, 184);
            m_arrColor[36] = RGB(255, 192, 111);
            m_arrColor[37] = RGB(0, 0, 128);
            m_arrColor[38] = RGB(39, 65, 118);
            m_arrColor[39] = RGB(106, 140, 203);
            m_arrColor[40] = RGB(109, 150, 208);
            m_arrColor[41] = RGB(246, 246, 246);
            m_arrColor[42] = RGB(230, 227, 210);
            m_arrColor[43] = RGB(0, 45, 150);
            m_arrColor[44] = RGB(0, 0, 0);
            m_arrColor[45] = RGB(0, 0, 0);
            m_arrColor[46] = RGB(0, 0, 0);
            m_arrColor[47] = RGB(0, 0, 0);
            m_arrColor[48] = RGB(255, 251, 233);
            m_arrColor[49] = RGB(129, 126, 114);
            m_arrColor[50] = RGB(0, 0, 128);
            m_arrColor[51] = RGB(236, 233, 216);
            m_arrColor[52] = RGB(172, 168, 153);
            m_arrColor[53] = RGB(239, 237, 222);
            m_arrColor[54] = RGB(0, 45, 150);
            m_arrColor[55] = RGB(236, 233, 216);
            m_arrColor[56] = RGB(236, 233, 216);
            m_arrColor[57] = RGB(127, 157, 185);
            m_arrColor[58] = RGB(180, 177, 163);
            m_arrColor[59] = RGB(0, 0, 0);
            m_arrColor[60] = RGB(180, 177, 163);
        }
    }
}

CColorSetOffice2003Ex::CColorSetOffice2003Ex(BOOL bGreyToBlue)
{
    m_bGreyToBlue = bGreyToBlue;
//    RefreshMetrics();
}

COLORREF CColorSetOffice2003Ex::FillClient(CDC* pDC, CRect rc, CXTPTabManager* pTabManager)
{
    pDC->FillSolidRect(rc, m_clrButtonNormal);
    return m_clrButtonNormal;
}

void CColorSetOffice2003Ex::RefreshMetrics()
{
    CColorSetOffice2003::RefreshMetrics();

    if( !m_bLunaTheme ) {
        CXTPColorManager *pClrMgr = XTPColorManager();
        COLORREF btn = pClrMgr->GetColor(COLOR_BTNFACE);
        if( m_bGreyToBlue && (btn == RGB(192, 192, 192) || btn == RGB(212, 208, 200) || btn == RGB(235, 233, 237)) ) {
            m_clrButtonHighlighted = RGB(255, 240, 201);
            m_clrNavigateButtonBorder = RGB(0, 0, 128);
            m_clrHeaderFace.clrDark = RGB(252, 253, 254);
            m_clrHeaderFace.clrLight = RGB(196, 218, 250);
            m_clrHeaderFace.fGradientFactor = 0.50f;
            m_clrAutoHideFace.clrDark = RGB(196, 218, 250);
            m_clrAutoHideFace.clrLight = RGB(158, 190, 245);
            m_clrAutoHideFace.fGradientFactor = 0.50f;
            m_clrFrameBorder = RGB(59, 97, 156);
            m_clrControlFace = RGB(236, 233, 216);
            m_clrHighlight = RGB(255, 255, 255);
            m_clrButtonSelected = RGB(255, 194, 115);
            m_clrButtonNormal = RGB(162, 192, 246);
            m_clrNormalText = RGB(0, 0, 0);
            m_clrInActiveText = RGB(0, 0, 0);
            m_clrSelectedText = RGB(0, 0, 0);
            m_clrHighlightText = RGB(0, 0, 0);
            m_clrDisabledText = RGB(172, 168, 153);
            m_csPropertyPage2003.clrDarkShadow = RGB(0, 53, 154);
            m_csPropertyPage2003.clrFrameBorder = RGB(59, 97, 156);
            m_csPropertyPage2003.clrBorderLeftHighlight = RGB(117, 166, 241);
            m_csPropertyPage2003.clrBorderTopHighlight = RGB(255, 255, 255);
            m_bLunaTheme = TRUE;
        }
    }
}

Maybe this can be done by using the following functions:

pCommandBars->GetPaintManager()->SetLunaTheme(xtpSyste mThemeBlue); - to make Blue theme for CommandBars only and

XTPColorManager()->SetLunaTheme(xtpSystemThemeBlue); - for all controls.

But, I have never seen these functions working! Any examples available using these functions?

I can't see any differences with or without the call to XTPColorManager()->SetLunaTheme(xtpSystemThemeBlue).

I have also tried with and without the following code to make this Office 2003 blue theme:
    CXTPOffice2003Theme::LoadModernToolbarIcons(IDR_MAINFRAME);
CXTPPaintManager::SetTheme(xtpThemeOffice2003);

pTabPaintManager->SetColorSet(new CColorSetOffice2003Ex());

m_DockingPaneManager.SetTheme(xtpPaneThemeOffice2003);

bool CMainFrameBase::Windows2000Setup() {
    // Set Office 2003 Theme
    XTAuxData().bXPMode = TRUE;
    XTThemeManager()->SetTheme(xtThemeOffice2003);
    CXTButton::SetDefaultTheme(new CXTButtonThemeOffice2003Ex());
    GetCommandBars()->SetPaintManager(new CXTPOffice2003ThemeEx());
    m_DockingPaneManager.SetCustomTheme(new CXTPDockingPaneOffice2003ThemeEx());
    m_DockingPaneManager.GetPaintManager()->GetTabPaintManage r()->SetColorSet(new CColorSetOffice2003Ex()) ;
    m_DockingPaneManager.GetPaintManager()->GetPanelPaintMana ger()->SetColorSet(new CColorSetOffice2003Ex());
    return true;
}

This is working fine (I get the Office 2003 blue theme), but it would be great to remove the non-codejock classes and use XTPColorManager()->SetLunaTheme(xtpSystemThemeBlue) - but I can't get it working. Do you have a very small sample using this function?

If I can get blue colors in toolbar, main frame menu, pane etc., I will be happy - but I can't see any blue colors when using the XTPColorManager()->SetLunaTheme(xtpSystemThemeBlue) function call...