BUG: XTPMarkupStatic unusable

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

Hi;

Since v15.2.1 the CTPMarkupStatic control is unusable if the markup text contains a % (percent) sign.
I found no breaking change news in readme of this version about this kind of annoying error. This code change required several working hours to be located and fixed by creating our own control!!!!
Taken a look at the code change I found out that the % sign is used as a splitter for caption/text combination.

Old code:
void CXTPMarkupStatic::SetMarkupText(LPCTSTR lpszMarkup)
{
    MARKUP_RELEASE(m_pUIElement);

    m_pUIElement = Parse(lpszMarkup);

    if (m_hWnd) Invalidate(FALSE);
}

New code:
void CXTPMarkupStatic::SetMarkupText(LPCTSTR lpszMarkup)
{
    MARKUP_RELEASE(m_pUIElement);

    if (lpszMarkup && _tcschr(lpszMarkup, _T('%')) != NULL)
    {
        CString strCaption;
        GetWindowText(strCaption);

        CString strMarkup;
        strMarkup.Format(lpszMarkup, (LPCTSTR)strCaption);  <-- This crashes (ACCVIO)

        m_pUIElement = m_pMarkupContext->Parse(strMarkup);
    }
    else
    {
        m_pUIElement = m_pMarkupContext->Parse(lpszMarkup);
    }

    if (m_hWnd) Invalidate(FALSE);
}

To CJ: It would be better to create a new function "SetMarkupTextEx" to extend the functionalities for your needs.
In any case, if you leave the code as is, the control is unusable in real world applications!