Codejock Developer Community

Command Bars : CXTPCommandBarAnimation::RedrawRect

Mon, 08 Jun 2026 16:24:25 +0000

Author: rdhd
Subject: CXTPCommandBarAnimation::RedrawRect
Posted: 08 June 2026 at 4:24pm

Looking at dump files where we crash in AlphaBlendU with a non-null pointer access violation, Claude Code has pointed to CXTPCommandBarAnimation::RedrawRect where lpRect == NULL.

CC thinks RemoveAnimations needs to be called there. I have verified debugging that if I have collapsed groups and click and move over etc. that function is called with a NULL lpRect. It is also called when we programmatically set the popup of a collapsed group with a "find command" tool we have. It is also called when clicking a button on the ribbon.

But still, I never crash. This is "random" in our code base. Can a CJ expert confirm or deny this change is needed:

void CXTPCommandBarAnimation::RedrawRect(LPCRECT lpRect, BOOL bAnimate)
{
if (lpRect == NULL)
{
m_bmpCache.DeleteObject();
RemoveAnimations();
}

So far in testing I find nothing bad happening. So, I got that going for me.

Skin Framework : Menu won't draw.

Mon, 08 Jun 2026 09:57:04 +0000

Author: rdhd
Subject: Menu won't draw.
Posted: 08 June 2026 at 9:57am

What I have isn't an MFC app though our app is based on MFC. The code I dropped is just "classic"/Petzold sort of programming.

Skin Framework : Menu won't draw.

Mon, 08 Jun 2026 07:30:48 +0000

Author: agontarenko
Subject: Menu won't draw.
Posted: 08 June 2026 at 7:30am

This is CFrameWnd base window (SDI) test.

Regards,

Artem Gontarenko

Skin Framework : Menu won't draw.

Mon, 08 Jun 2026 05:33:18 +0000

Author: agontarenko
Subject: Menu won't draw.
Posted: 08 June 2026 at 5:33am

Skin Framework : Menu won't draw.

Mon, 08 Jun 2026 05:32:46 +0000

Author: agontarenko
Subject: Menu won't draw.
Posted: 08 June 2026 at 5:32am

Skin Framework : Menu won't draw.

Mon, 08 Jun 2026 05:31:39 +0000

Author: agontarenko
Subject: Menu won't draw.
Posted: 08 June 2026 at 5:31am

Hello,

I've created test MFC project with ownerdraw menu, then add CJ skin and menu, rename CWinApp -> CXTPWinApp and all works as expected.

See please my test project.

Regards,

Artem Gontarenko

uploads/9012/MFCMenuApp.zip

Toolkit Pro : Toolset update

Fri, 05 Jun 2026 00:57:54 +0000

Author: astoyan
Subject: Toolset update
Posted: 05 June 2026 at 12:57am

Hello Piotr,

Visual Studio 2026 official support will be added in the upcoming version. The currently available v24.3 does not provide an official support for it.

Regards,

Alexander

Toolkit Pro : TaskDialog infinite loop on an error case

Fri, 05 Jun 2026 00:55:31 +0000

Author: astoyan
Subject: TaskDialog infinite loop on an error case
Posted: 05 June 2026 at 12:55am

Thanks for reporting this mistake. Indeed, the return value must be -1. I'll be fixed in the upcoming version.

Regards,

Alexander

Toolkit Pro : TaskDialog infinite loop on an error case

Wed, 03 Jun 2026 05:54:30 +0000

Author: Julianis
Subject: TaskDialog infinite loop on an error case
Posted: 03 June 2026 at 5:54am

We are using an CXTPTaskDialog in our application.

I'm using incorrect settings and the dialog fails to create.
In this case the application ends up in an infinite loop.

The culprit seems to be the handling of the error case in

int CXTPTaskDialogFrame::OnCreate(LPCREATESTRUCT lpCreateStruct)
{
  ...
  	if (!CreateClient(TRUE))	{		TRACE0("Failed to create Task Dialog UI window.\n");		return FALSE;	}
}

The return FALSE seems to be incorrect (the method returns 0 as success).

If I patch the code with a return -1 when CreateClient() fails, the infinite loop no longer happens.

Skin Framework : Menu won't draw.

Thu, 28 May 2026 18:23:31 +0000

Author: rdhd
Subject: Menu won't draw.
Posted: 28 May 2026 at 6:23pm

Hi Alexander,

Thanks for putting it on a list. Looks like the code is always calling GetSysMenu even when GetMenu(m_hWnd) returns the menu in question.